You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I will take a look. It looks like it was intended to be reentrant (I did not write this code) but I also don't have a good use case for updating mode at runtime so your proposal may be fine.
The issue is that I think this will break the app memory being released in the case where someone destroys the component element in the page. I.e., recreating to change scene rather than using the app reload functionality.
If I try to call
taskProvider.ins.mode.setValue(3)
- or whatever number, after voyager story has initialized, everything breaks.The funny thing is: it breaks even before
CVTaskManager.update()
gets called.I looked around a bit and it might not be easy to make this reentrant. Maybe the easiest fix would be to prevent modification like this:
Or there is an easy(ish) fix that I missed? I'm not yet familiar enough with this part of the code.
The text was updated successfully, but these errors were encountered: