-
Notifications
You must be signed in to change notification settings - Fork 16
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
style: Added uncrustify precommit hook
- Loading branch information
Showing
3 changed files
with
217 additions
and
0 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,48 @@ | ||
#!/bin/sh | ||
|
||
# Provide the canonicalize filename (physical filename with out any symlinks) | ||
# like the GNU version readlink with the -f option regardless of the version of | ||
# readlink (GNU or BSD). | ||
|
||
# This file is part of a set of unofficial pre-commit hooks available | ||
# at github. | ||
# Link: https://github.com/githubbrowser/Pre-commit-hooks | ||
# Contact: David Martin, david.martin.mailbox@googlemail.com | ||
|
||
########################################################### | ||
# There should be no need to change anything below this line. | ||
|
||
# Canonicalize by recursively following every symlink in every component of the | ||
# specified filename. This should reproduce the results of the GNU version of | ||
# readlink with the -f option. | ||
# | ||
# Reference: http://stackoverflow.com/questions/1055671/how-can-i-get-the-behavior-of-gnus-readlink-f-on-a-mac | ||
canonicalize_filename () { | ||
local target_file="$1" | ||
local physical_directory="" | ||
local result="" | ||
|
||
# Need to restore the working directory after work. | ||
local working_dir="`pwd`" | ||
|
||
cd -- "$(dirname -- "$target_file")" | ||
target_file="$(basename -- "$target_file")" | ||
|
||
# Iterate down a (possible) chain of symlinks | ||
while [ -L "$target_file" ] | ||
do | ||
target_file="$(readlink -- "$target_file")" | ||
cd -- "$(dirname -- "$target_file")" | ||
target_file="$(basename -- "$target_file")" | ||
done | ||
|
||
# Compute the canonicalized name by finding the physical path | ||
# for the directory we're in and appending the target file. | ||
physical_directory="`pwd -P`" | ||
result="$physical_directory/$target_file" | ||
|
||
# restore the working directory after work. | ||
cd -- "$working_dir" | ||
|
||
echo "$result" | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,4 @@ | ||
#!/bin/sh | ||
|
||
rm -Rf .git/hooks | ||
ln -s ../.githooks .git/hooks |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,165 @@ | ||
#!/bin/sh | ||
|
||
# git pre-commit hook that runs an Uncrustify stylecheck. | ||
# Features: | ||
# - abort commit when commit does not comply with the style guidelines | ||
# - create a patch of the proposed style changes | ||
# | ||
# More info on Uncrustify: http://uncrustify.sourceforge.net/ | ||
|
||
# This file is part of a set of unofficial pre-commit hooks available | ||
# at github. | ||
# Link: https://github.com/githubbrowser/Pre-commit-hooks | ||
# Contact: David Martin, david.martin.mailbox@googlemail.com | ||
|
||
|
||
################################################################## | ||
# CONFIGURATION | ||
# set uncrustify path or executable | ||
# UNCRUSTIFY="/usr/bin/uncrustify" | ||
UNCRUSTIFY="uncrustify" | ||
|
||
# set uncrustify config location | ||
# CONFIG="/home/user/.config/uncrustify.cfg" | ||
CONFIG=".uncrustify.cfg" | ||
|
||
# the source language: C, CPP, D, CS, JAVA, PAWN, VALA, OC, OC+ | ||
# use AUTO to let Uncrustify decide which language a given file uses. | ||
# the detected language is printed to the console when Uncrustify is called. | ||
# override if the automatic detection seems off. | ||
# SOURCE_LANGUAGE="AUTO" | ||
SOURCE_LANGUAGE="AUTO" | ||
|
||
# remove any older patches from previous commits. Set to true or false. | ||
# DELETE_OLD_PATCHES=false | ||
DELETE_OLD_PATCHES=false | ||
|
||
# only parse files with the extensions in FILE_EXTS. Set to true or false. | ||
# if false every changed file in the commit will be parsed with Uncrustify. | ||
# if true only files matching one of the extensions are parsed with Uncrustify. | ||
# PARSE_EXTS=true | ||
PARSE_EXTS=true | ||
|
||
# file types to parse. Only effective when PARSE_EXTS is true. | ||
# FILE_EXTS=".c .h .cpp .hpp" | ||
FILE_EXTS=".c .h .cc .hh .cpp .hpp .hxx" | ||
|
||
################################################################## | ||
# There should be no need to change anything below this line. | ||
|
||
. "$(dirname -- "$0")/canonicalize_filename.sh" | ||
|
||
# exit on error | ||
set -e | ||
|
||
# check whether the given file matches any of the set extensions | ||
matches_extension() { | ||
local filename="$(basename -- "$1")" | ||
local extension=".${filename##*.}" | ||
local ext | ||
|
||
for ext in $FILE_EXTS; do [ "$ext" = "$extension" ] && return 0; done | ||
|
||
return 1 | ||
} | ||
|
||
# necessary check for initial commit | ||
if git rev-parse --verify HEAD >/dev/null 2>&1 ; then | ||
against=HEAD | ||
else | ||
# Initial commit: diff against an empty tree object | ||
against=4b825dc642cb6eb9a060e54bf8d69288fbee4904 | ||
fi | ||
|
||
# make sure the config file and executable are correctly set | ||
if [ ! -f "$CONFIG" ] ; then | ||
printf "Error: uncrustify config file not found.\n" | ||
printf "Set the correct path in $(canonicalize_filename "$0").\n" | ||
exit 1 | ||
fi | ||
|
||
if ! command -v "$UNCRUSTIFY" > /dev/null ; then | ||
printf "Error: uncrustify executable not found.\n" | ||
printf "Set the correct path in $(canonicalize_filename "$0").\n" | ||
exit 1 | ||
fi | ||
|
||
# create a filename to store our generated patch | ||
prefix="pre-commit-uncrustify" | ||
suffix="$(date +%C%y-%m-%d_%Hh%Mm%Ss)" | ||
patch="/tmp/$prefix-$suffix.patch" | ||
|
||
# clean up any older uncrustify patches | ||
$DELETE_OLD_PATCHES && rm -f /tmp/$prefix*.patch | ||
|
||
# create one patch containing all changes to the files | ||
# sed to remove quotes around the filename, if inserted by the system | ||
# (done sometimes, if the filename contains special characters, like the quote itself) | ||
git diff-index --cached --diff-filter=ACMR --name-only $against -- | \ | ||
sed -e 's/^"\(.*\)"$/\1/' | \ | ||
while read file | ||
do | ||
# ignore file if we do check for file extensions and the file | ||
# does not match any of the extensions specified in $FILE_EXTS | ||
if $PARSE_EXTS && ! matches_extension "$file"; then | ||
continue; | ||
fi | ||
|
||
# escape special characters in the source filename: | ||
# - '\': backslash needs to be escaped | ||
# - '*': used as matching string => '*' would mean expansion | ||
# (curiously, '?' must not be escaped) | ||
# - '[': used as matching string => '[' would mean start of set | ||
# - '|': used as sed split char instead of '/', so it needs to be escaped | ||
# in the filename | ||
# printf %s particularly important if the filename contains the % character | ||
file_escaped_source=$(printf "%s" "$file" | sed -e 's/[\*[|]/\\&/g') | ||
|
||
# escape special characters in the target filename: | ||
# phase 1 (characters escaped in the output diff): | ||
# - '\': backslash needs to be escaped in the output diff | ||
# - '"': quote needs to be escaped in the output diff if present inside | ||
# of the filename, as it used to bracket the entire filename part | ||
# phase 2 (characters escaped in the match replacement): | ||
# - '\': backslash needs to be escaped again for sed itself | ||
# (i.e. double escaping after phase 1) | ||
# - '&': would expand to matched string | ||
# - '|': used as sed split char instead of '/' | ||
# printf %s particularly important if the filename contains the % character | ||
file_escaped_target=$(printf "%s" "$file" | sed -e 's/[\"]/\\&/g' -e 's/[\&|]/\\&/g') | ||
|
||
# Uncrustify detects the language automatically if it is not specified | ||
language_option="" | ||
if [ "$SOURCE_LANGUAGE" != "AUTO" ] ; then | ||
language_option="-l $SOURCE_LANGUAGE" | ||
fi | ||
|
||
# uncrustify our sourcefile, create a patch with diff and append it to our $patch | ||
# The sed call is necessary to transform the patch from | ||
# --- $file timestamp | ||
# +++ - timestamp | ||
# to both lines working on the same file and having a a/ and b/ prefix. | ||
# Else it can not be applied with 'git apply'. | ||
"$UNCRUSTIFY" -c "$CONFIG" -f "$file" $language_option | \ | ||
git --no-pager diff --color=always --no-index -- "$file" - | \ | ||
sed -e "1s|--- $file_escaped_source|--- \"a/$file_escaped_target\"|" -e "2s|+++ -|+++ \"b/$file_escaped_target\"|" >> "$patch" | ||
done | ||
|
||
# if no patch has been generated all is ok, clean up the file stub and exit | ||
if [ ! -s "$patch" ] ; then | ||
printf "Files in this commit comply with the uncrustify rules.\n" | ||
rm -f "$patch" | ||
exit 0 | ||
fi | ||
|
||
# a patch has been created, notify the user and exit | ||
printf "\nThe following differences were found between the code to commit " | ||
printf "and the uncrustify rules:\n\n" | ||
cat "$patch" | ||
|
||
printf "\nYou can apply these changes with:\n git apply $patch\n" | ||
printf "(may need to be called from the root directory of your repository)\n" | ||
printf "Aborting commit. Apply changes and commit again or skip checking with" | ||
printf " --no-verify (not recommended).\n" | ||
|
||
exit 1 |