Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add RISC-V support #46

Merged
merged 1 commit into from
Mar 22, 2023
Merged

Add RISC-V support #46

merged 1 commit into from
Mar 22, 2023

Conversation

Sakura286
Copy link
Contributor

Add riscv64 trampoline. All tests in Criterion has passed. Here is the test log.

Copy link
Collaborator

@MrAnno MrAnno left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wow! Thank you for this pull request.

@MrAnno MrAnno merged commit c91d718 into Snaipe:master Mar 22, 2023
@Snaipe
Copy link
Owner

Snaipe commented Mar 27, 2023

Awesome!

I'd rather not leave this untested though. There's no riscv support on Alpine Linux to build a proper snaipe/ci-meson image with qemu-user as a foreign-arch binfmt interpreter, but maybe we can add a job to cross-compile the test binaries on riscv64, then use qemu-user-riscv64 to run them?

@Sakura286
Copy link
Contributor Author

Yes, it should be tested.

I tried to cross-build to riscv64 in amd64 Debian/Ubuntu on Cirrus CI , Github Action , local Docker. The script does the same thing, but only test on Cirrus CI failed because of CoreDump (see script on my branch: Sakura286@e04455025). I haven't figured out why this happend till now.

Does this subject accept other CI if Cirrus is not usable?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants