WIP: Add support to use system libraries #803
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add a new USE_SYSTEM_CONCURRENTQUEUE make variable to select whether to include the system concurrentqueue headers.
Add a new USE_SYSTEM_JEMALLOC make variable to select whether to link against the system libjemalloc.
Add a new USE_SYSTEM_ROCKSDB make variable to select whether to link against the system librocksdb.
…_ssl Add a new USE_SYSTEM_HIREDIS make variable to select whether to link against the system libhiredis (and libhiredis_ssl if BUILD_TLS is enabled). Move the sdscompat.h header from the vendored hiredis directory to src/, as this file is not and has never been part of the upstream hiredis project, it got added in commit bffbbea in redis itself.
|
Looks reasonable. CI failure is unrelated (flaky test) |
JohnSully
approved these changes
Mar 26, 2024
|
Thanks for merging! Unfortunately the hiredis change was not entirely correct, which I detected after bisecting for the test failures I mentioned in my initial message. :) I'm sending a new MR to fix that up. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These patches add support to optionally use system libraries instead of the vendored (or embedded) projects. This was requested in #493. I'm sending what I've got for now to avoid duplicated work, even though this does not seem to be passing the tests yet. I'll try to check which commit makes it fail next week. I've left out for now the lua vendored code, because I cannot test that with what is currently packaged in Debian as there are at least two lua modules missing there. My current WIP for that is in guillemj@5bbff3c.
This is something that is required by most major distributions as a matter of policy, and something that will need to be carried over when packaging for Debian (or Fedora I guess), see https://bugs.debian.org/1067413.