Feature: Add object multiple selection support for 3D printing #413
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jane-rose
changed the title
jane-rose
changed the title
jane-rose
changed the title
parachvte
requested changes
Aug 14, 2020
src/app/widgets/PrintingVisualizer/VisualizerModelTransformation.jsx
Outdated
Show resolved
Hide resolved
parachvte
reviewed
Aug 14, 2020
jane-rose
force-pushed
the
feature-add-multiselect-in-3dp
branch
from
1f9abca
to
5629972
Compare
src/app/flux/printing/index.js
Outdated
| dispatch(actions.displayModel()); | ||
| }, | ||
|
|
||
| selectMultiModel: (selectedGroup) => (dispatch, getState) => { |
There was a problem hiding this comment.
suggest: implement and trigger refresh in modelgroup.js
src/app/flux/printing/index.js
Outdated
|
|
||
| selectTargetModel: (model, isMultiSelect) => (dispatch, getState) => { | ||
| const { modelGroup } = getState().printing; | ||
| const modelState = modelGroup.selectModelById([model], isMultiSelect); |
There was a problem hiding this comment.
selecteModelById need an modelID, here is an array
| getSelectedModel: () => (dispatch, getState) => { | ||
| const { modelGroup } = getState().printing; | ||
| return modelGroup.selectedModel; | ||
| }, | ||
|
|
||
| getSelectedModelArray: () => (dispatch, getState) => { |
There was a problem hiding this comment.
suggest: we can get modelGroup attributes in connected components directly
| @@ -796,23 +837,23 @@ export const actions = { | |||
| } | |||
| }, | |||
|
|
|||
| selectAllModels: () => (dispatch, getState) => { | |||
There was a problem hiding this comment.
suggest: modelState is deprecated, map modelGroup attributes to refresh components
parachvte
reviewed
Aug 26, 2020
parachvte
reviewed
Aug 26, 2020
parachvte
reviewed
Aug 26, 2020
parachvte
reviewed
Aug 26, 2020
parachvte
reviewed
Aug 26, 2020
| @@ -17,6 +18,8 @@ import { | |||
| MeshBasicMaterial, | |||
| LineBasicMaterial | |||
| } from 'three'; | |||
| // import * as THREE from 'three'; | |||
parachvte
reviewed
Aug 26, 2020
parachvte
reviewed
Aug 26, 2020
| this.dispatchEvent(EVENTS.UPDATE); | ||
| } | ||
|
|
||
|
|
parachvte
reviewed
Aug 26, 2020
| detach() { | ||
| this.object = null; | ||
| // this.object = new Group(); |
parachvte
reviewed
Aug 26, 2020
parachvte
reviewed
Aug 26, 2020
| @@ -677,7 +677,7 @@ class Visualizer extends Component { | |||
| <Canvas | |||
| ref={this.canvas} | |||
| size={this.props.size} | |||
| modelGroup={this.visualizerGroup} | |||
| modelGroup={{ object: this.visualizerGroup }} | |||
There was a problem hiding this comment.
Avoid re-creation of temporary objects.
parachvte
requested changes
Aug 26, 2020
parachvte
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.