Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature/ci_coverage #119

Merged
merged 41 commits into from Oct 17, 2020
Merged

feature/ci_coverage #119

merged 41 commits into from Oct 17, 2020

Conversation

Snayff
Copy link
Owner

@Snayff Snayff commented Oct 9, 2020

No description provided.

@Snayff
Copy link
Owner Author

Snayff commented Oct 10, 2020

Deps still being installed every time. Using the if check (currently commented out) stops the deps installing when the cache is retrieved but causes all future steps to fall over with command not recognised.

Coverage still not being picked up.

@Snayff Snayff marked this pull request as draft October 10, 2020 10:30
@Snayff Snayff marked this pull request as ready for review October 17, 2020 12:00
@codecov-io
Copy link

Codecov Report

❗ No coverage uploaded for pull request base (develop@9355a4b). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             develop     #119   +/-   ##
==========================================
  Coverage           ?   90.43%           
==========================================
  Files              ?        6           
  Lines              ?      115           
  Branches           ?        0           
==========================================
  Hits               ?      104           
  Misses             ?       11           
  Partials           ?        0           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9355a4b...f18d181. Read the comment docs.

@sonarcloud
Copy link

sonarcloud bot commented Oct 17, 2020

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities (and Security Hotspot 0 Security Hotspots to review)
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@Snayff Snayff merged commit b31c0b2 into develop Oct 17, 2020
@Snayff Snayff deleted the feature/ci_coverage branch October 17, 2020 12:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants