gj #1
Merged
gj #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The canonical Git client successfully decodes sideband packets up to 65524 bytes in length (4-byte header + 65520-byte payload). The Git protocol documentation was updated in August 2016 to reduce the maximum payload size to 65516 bytes, however old implementations still exist in the wild emitting 65520-byte payloads. As there is no technical difficulty with accepting (not emitting) larger payload sizes, this change adjusts the limit check to allow successful decoding of packets up to 65524 bytes. This change increases compatibility with the current canonical Git implementation. Doc changes from August 2016: git/git@7841c48#diff-52695c8fe91b78b70cea44562ae28297L67 Current packet buffer size is still LARGE_PACKET_MAX (+1 null): https://github.com/git/git/blob/468165c1d8a442994a825f3684528361727cd8c0/sideband.c#L24 https://github.com/git/git/blob/468165c1d8a442994a825f3684528361727cd8c0/sideband.c#L36 LARGE_PACKET_MAX definition: https://github.com/git/git/blob/468165c1d8a442994a825f3684528361727cd8c0/pkt-line.h#L100 Signed-off-by: Joseph Vusich <jvusich@amazon.com>
plumbing: format: pktline, Accept oversized pkt-lines up to 65524 bytes
This is the git tool's behavior that people are used to; if one runs a git command in a repository's subdirectory, git still works. Fixes #765. Signed-off-by: Daniel Martí <mvdan@mvdan.cc>
add PlainOpen variant to find .git in parent dirs
Signed-off-by: wardn <wardn@users.noreply.github.com>
…, updates clone to track when cloning a branch. Fixes #313 Signed-off-by: Jeremy Chambers <jeremy@thehipbot.com>
use bsd superset for conditional compilation
config: adds branches to config for tracking branches against remotes…
For both packfiles and object files. Issue: keybase/client#11366 Signed-off-by: Jeremy Stribling <strib@alum.mit.edu>
fixtures is not initialized in BenchmarkRefMultipleTimes and caused panic. Signed-off-by: Javi Fontan <jfontan@gmail.com>
storage: dotgit, init fixtures in benchmark. Fixes #770
updateShallow substituted the previous shallow list with the one returned by the UploadPackResponse. If the repository had previous shallow commits these are deleted from the list. This change adds the new shallow hashes to the old ones. Signed-off-by: Javi Fontan <jfontan@gmail.com>
Suggested by mcuadros. Issue: #807 Signed-off-by: Jeremy Stribling <strib@alum.mit.edu>
Signed-off-by: antham <hamonanth@gmail.com>
dotgit: ignore filenames that don't match a hash
git: remote, Add shallow commits instead of substituting. Fixes #412
Signed-off-by: Máximo Cuadros <mcuadros@gmail.com>
Resolve full commit sha
Signed-off-by: kuba-- <kuba@sourced.tech>
Fix for "Worktree Add function adds ".git" directory"
Fixes #827 Signed-off-by: Dustin Frisch <fooker@lab.sh>
Worktree: Provide ability to add excludes
Signed-off-by: Mike Lundy <mike@fluffypenguin.org>
The current code iterates all the references in the remote to check if they match the refspec. This is OK when the refspec is a wildcard but is a waste of time when they are not. A hash with references is generated for fast access before starting the update and used only when the refspec is not a wildcard. In a repository with 7800 references this meant 7800 * 7800 checks. With the current code it took 8m30s to update the references. With the new code it takes less than 0.5s. References are already extensively tested in remote_test.go. Signed-off-by: Javi Fontan <jfontan@gmail.com>
git: remote, Do not iterate all references on update.
This makes all the required Entry allocations in one go, instead of huge amounts of small individual allocations. Signed-off-by: David Symonds <dsymonds@golang.org>
Instead of using a map for offset indexing, use a sorted slice. Binary searching is fast, and a slice is much more compact. This has a negligible hit on speed, but has a significant impact on memory usage, especially for larger repos. benchmark old ns/op new ns/op delta BenchmarkIndexConstruction-12 15506506 14056098 -9.35% benchmark old allocs new allocs delta BenchmarkIndexConstruction-12 60764 60385 -0.62% benchmark old bytes new bytes delta BenchmarkIndexConstruction-12 4318145 3913169 -9.38% Signed-off-by: David Symonds <dsymonds@golang.org>
…Fixes CVE-2018-11235 References: * https://blogs.msdn.microsoft.com/devops/2018/05/29/announcing-the-may-2018-git-security-vulnerability/ * https://security-tracker.debian.org/tracker/CVE-2018-11235 * git/git@0383bbb Signed-off-by: Joseph Vusich <jvusich@amazon.com>
References: * https://blogs.msdn.microsoft.com/devops/2018/05/29/announcing-the-may-2018-git-security-vulnerability/ * https://security-tracker.debian.org/tracker/CVE-2018-11235 * git/git@10ecfa7 Signed-off-by: Joseph Vusich <jvusich@amazon.com>
Since we are not redirecting users to StackOverflow for support questions, it makes sense to add it to the official support channels. Signed-off-by: Santiago M. Mola <santi@mola.io>
add StackOverflow to support channels
Signed-off-by: Dave Henderson <dhenderson@gmail.com>
plumbing: transport/http, Add missing host/port on redirect. Fixes #820
Signed-off-by: Lukasz Kokot <lukasz@kumojin.com>
…ample Fix spelling and grammar in docs and example
Signed-off-by: Dave Henderson <dhenderson@gmail.com>
update gcfg dependency to v1.4.0
Signed-off-by: Bartek Jaroszewski <jaroszewskibartek@gmail.com>
Signed-off-by: Santiago M. Mola <santi@mola.io>
cleanup after failed clone
Signed-off-by: Máximo Cuadros <mcuadros@gmail.com>
Users are often confused with TokenAuth, since it might look that it should be used with GitHub's OAuth tokens. But that is not the case. TokenAuth implements HTTP bearer authentication. Most git servers will use HTTP basic authentication (user+passwords) even for OAuth tokens. Signed-off-by: Santiago M. Mola <santi@mola.io>
http: improve TokenAuth documentation
…#969 Signed-off-by: Colton McCurdy <mccurdyc22@gmail.com>
…969/fix-flaky-ssh-test
…sh-test plumbing: ssh, Fix flaky test TestAdvertisedReferencesNotExists. Fixes #969
Signed-off-by: Fedor Korotkov <fedor.korotkov@gmail.com>
repository: Fix RefSpec for a single tag.
Signed-off-by: Javier Peletier <jm@epiclabs.io>
Signed-off-by: Javier Peletier <jm@epiclabs.io>
Signed-off-by: Antonio Jesus Navarro Perez <antnavper@gmail.com>
plumbing/format/packfile: Fix broken "thin" packfile support. Fixes #991
storage/filesystem: Added reindex method to reindex packfiles
… v2.2.0 Signed-off-by: Máximo Cuadros <mcuadros@gmail.com>
plumbing: format/index: support for EOIE extension
repository: fix plain clone error handling regression
…e commit histories (#963) Signed-off-by: Filip Navara <navara@emclient.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.