Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

VRT/ET/Local rule look-ups by assigned sid range. #138

Closed
wmetcalf opened this issue Sep 14, 2011 · 4 comments
Closed

VRT/ET/Local rule look-ups by assigned sid range. #138

wmetcalf opened this issue Sep 14, 2011 · 4 comments

Comments

@wmetcalf
Copy link

Can we have a rule look-ups become rule range aware? Something like the following(git patch)?

http://pastebin.com/EhVttJ3G

Please excuse the pastebin, but annoyingly github does not allow you to attach files to issues. Also please excuse the code if it is crap, I've never written anything in ruby before.

@shadowbq
Copy link
Contributor

shadowbq commented Nov 1, 2011

 if signature.sig_sid <= 1000000
+      @signature_url = if Setting.vrt_signature_lookup?
+        Setting.find(:vrt_signature_lookup)
+      else
+        VRT_SIGNATURE_URL
+      end
+    elsif (signature.sig_sid > 1000000) && (signature.sig_sid < 2000000)
+      @signature_url = if Setting.local_signature_lookup?
+        Setting.find(:local_signature_lookup)
+      else
+        LOCAL_SIGNATURE_URL
+      end
+    elsif (signature.sig_sid >= 2000000) && (signature.sig_sid < 3000000)
+      @signature_url = if Setting.et_signature_lookup?
+        Setting.find(:et_signature_lookup)
+      else

Signature SIDS dont really have a dedicated range and this is just best guessing. SIDs are generally a mess.

@wmetcalf
Copy link
Author

wmetcalf commented Nov 1, 2011

According to the snort manual there is a dedicated range http://manual.snort.org/node30.html#keyword_sid . Although this specifies that sids > 1000000 are for local use. While this might be the "official" stance, the reality of the situation is that there are a lot of ET users. Or perhaps there are VRT users that cherry pick sigs from the ET rule set. Maybe the best course of action is to allow users to simply specify non-overlapping ranges and then define a lookup source per range, something similar to the ip lookup sources. Thoughts?

@djcas9
Copy link
Contributor

djcas9 commented Jan 28, 2012

@wmetcalf any more progress on this - @shadowbq what do you think?

@shadowbq
Copy link
Contributor

Will has a good idea, possibly allow regex match to msg field. Given the
problems. Defining sid ranges for lookups could help. The hardest thing is
that snorby != sensor.. And snorby!=rulemngt So 'requiring' anything in a
rule such as meta tags doesnt help in this situation.
On Jan 28, 2012 1:03 PM, "Dustin Webber" <
reply@reply.github.com>
wrote:

@wmetcalf any more progress on this - @shadowbq what do you think?


Reply to this email directly or view it on GitHub:
#138 (comment)

@djcas9 djcas9 closed this as completed May 5, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants