pack assets #344
Closed
pack assets #344
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I also just realized, that I missed to do some changes to erb files (my regular expressions did not find all URLs within the snorby code). Await some more commits in this area during the next couple of days, you might also postpone merging this pull request... peter |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After my yesterday pull request and the resync with upstream, I realized that packed assets are part of the repo itself. But they were not included in the changeset, so people cloning the master would likely not be able to use the new baseuri feature.
The baseuri-master branch I herewith kindly ask you to pull, corrects this issue.
Thanks a lot!
peter