Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added tox configuration and updating dependency reqs #166

Closed
wants to merge 5 commits into from
Closed

Added tox configuration and updating dependency reqs #166

wants to merge 5 commits into from

Conversation

IndexSeek
Copy link
Collaborator

@IndexSeek IndexSeek commented Mar 26, 2023

Updating requirements and adding tox.

The current repo is using a Dockerfile to test Python 3.9 compatibility. I'm proposing using tox to automatically execute tests across different versions of Python.

There have been some inconsistencies recently with the cryptography and pyOpenSSL libraries between versions and I'm hoping this will ensure we can safely test the package installs and unit tests on each version of Python that schemachange supports.

Closes #165

@IndexSeek
Copy link
Collaborator Author

IndexSeek commented Mar 26, 2023

I updated the setup and requirements to support a looser restriction around the required snowflake-connector-python package.

After this change and running tox each environment successfully installed and tests passed.

.pkg: _exit> python venv\lib\site-packages\pyproject_api\_backend.py True setuptools.build_meta
  lint: OK (5.67=setup[4.47]+cmd[1.20] seconds)
  type: OK (5.25=setup[3.66]+cmd[1.59] seconds)
  py37: OK (30.99=setup[28.97]+cmd[2.02] seconds)
  py38: OK (4.73=setup[3.64]+cmd[1.09] seconds)
  py39: OK (4.64=setup[3.56]+cmd[1.08] seconds)
  py310: OK (4.76=setup[3.64]+cmd[1.12] seconds)
  congratulations :) (56.16 seconds)

@IndexSeek IndexSeek changed the title Added tox configuration Added tox configuration and updating dependency reqs Mar 26, 2023
@fozcodes
Copy link

Any chance this can be merged? This is preventing us from using the newest connector in a lot of projects.

@svitty
Copy link

svitty commented Jun 20, 2023

@sfc-gh-jhansen
FriendsChandlerBingGIF

@ryan-keswick
Copy link

pls, my dependabot is crying

@harringj
Copy link

harringj commented Jul 7, 2023

@sfc-gh-jhansen, do you have any sense of when this PR might get merged? i noticed that no commits have occurred since Feb 15 of this year. should we assume this project will no longer be maintained? thank you!

@sfc-gh-jhansen
Copy link
Collaborator

Included in the new 3.5.3 release. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

snowflake-connector-python version requirement
6 participants