chore: Extract reviewdog job from integration workflow (#2027)

* Move lint-ci to other workflow

* Mess with imports intentionally

Expecting to get message on PR about the file not being `go-fumpt`ed.

* Change the order of checks

* Fix imports to pass linters

This is the revert of the intentional format change earlier.

.github/workflows/go-fmt.yml

@@ -34,5 +34,10 @@ jobs:
       - name: Install golangci-lint
         run: make dev-setup
 
+      - name: make lint-ci integration
+        env:
+          REVIEWDOG_GITHUB_API_TOKEN: ${{ secrets.GITHUB_TOKEN }}
+        run: make lint-ci
+
       - name: Run golangci-lint
         run: make lint-check

.github/workflows/integration.yml

@@ -50,20 +50,9 @@ jobs:
       - name: Install dependencies
         run: make dev-setup
 
-      - name: make lint-ci integration
-        env:
-          REVIEWDOG_GITHUB_API_TOKEN: ${{ secrets.GITHUB_TOKEN }}
-          SNOWFLAKE_USER: ${{ secrets.SNOWFLAKE_USER }}
-          SNOWFLAKE_PASSWORD: ${{ secrets.SNOWFLAKE_PASSWORD }}
-          SNOWFLAKE_ACCOUNT: ${{ secrets.SNOWFLAKE_ACCOUNT }}
-          SNOWFLAKE_ROLE: ${{ secrets.SNOWFLAKE_ROLE }}
-          SNOWFLAKE_WAREHOUSE: ${{ secrets.SNOWFLAKE_WAREHOUSE }}
-        run: make lint-ci
-
       - name: make test-acceptance integration
         if: always()
         env:
-          REVIEWDOG_GITHUB_API_TOKEN: ${{ secrets.GITHUB_TOKEN }}
           SNOWFLAKE_USER: ${{ secrets.SNOWFLAKE_USER }}
           SNOWFLAKE_PASSWORD: ${{ secrets.SNOWFLAKE_PASSWORD }}
           SNOWFLAKE_ACCOUNT: ${{ secrets.SNOWFLAKE_ACCOUNT }}
@@ -76,7 +65,6 @@ jobs:
       - name: sweepers cleanup
         if: always()
         env:
-          REVIEWDOG_GITHUB_API_TOKEN: ${{ secrets.GITHUB_TOKEN }}
           SNOWFLAKE_USER: ${{ secrets.SNOWFLAKE_USER }}
           SNOWFLAKE_PASSWORD: ${{ secrets.SNOWFLAKE_PASSWORD }}
           SNOWFLAKE_ACCOUNT: ${{ secrets.SNOWFLAKE_ACCOUNT }}