Skip to content

Commit

Permalink
fix: 1969 change default privilege to OPERATE (#1970)
Browse files Browse the repository at this point in the history
* default privilege to OPERATE

* Add acceptance test.

---------

Co-authored-by: Nathan Gaberel <nathan.gaberel@snowflake.com>
  • Loading branch information
ndavies-om1 and sfc-gh-ngaberel committed Jul 24, 2023
1 parent 707d723 commit e8721f0
Show file tree
Hide file tree
Showing 2 changed files with 91 additions and 1 deletion.
2 changes: 1 addition & 1 deletion pkg/resources/pipe_grant.go
Original file line number Diff line number Diff line change
Expand Up @@ -42,7 +42,7 @@ var pipeGrantSchema = map[string]*schema.Schema{
Type: schema.TypeString,
Optional: true,
Description: "The privilege to grant on the current or future pipe. To grant all privileges, use the value `ALL PRIVILEGES`",
Default: "USAGE",
Default: "OPERATE",
ValidateFunc: validation.StringInSlice(validPipePrivileges.ToList(), true),
ForceNew: true,
},
Expand Down
90 changes: 90 additions & 0 deletions pkg/resources/pipe_grant_acceptance_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -48,6 +48,35 @@ func TestAcc_PipeGrant(t *testing.T) {
})
}

func TestAcc_PipeGrantWithDefaultPrivilege(t *testing.T) {
accName := strings.ToUpper(acctest.RandStringFromCharSet(10, acctest.CharSetAlpha))

resource.Test(t, resource.TestCase{
Providers: providers(),
CheckDestroy: nil,
Steps: []resource.TestStep{
{
Config: pipeGrantConfigWithDefaultPrivilege(accName),
Check: resource.ComposeTestCheckFunc(
resource.TestCheckResourceAttr("snowflake_pipe_grant.test", "database_name", accName),
resource.TestCheckResourceAttr("snowflake_pipe_grant.test", "schema_name", accName),
resource.TestCheckResourceAttr("snowflake_pipe_grant.test", "pipe_name", accName),
resource.TestCheckResourceAttr("snowflake_pipe_grant.test", "with_grant_option", "false"),
resource.TestCheckResourceAttr("snowflake_pipe_grant.test", "privilege", "OPERATE"),
),
},
{
ResourceName: "snowflake_pipe_grant.test",
ImportState: true,
ImportStateVerify: true,
ImportStateVerifyIgnore: []string{
"enable_multiple_grants", // feature flag attribute not defined in Snowflake, can't be imported
},
},
},
})
}

func pipeGrantConfig(name, privilege string) string {
s := `
resource "snowflake_database" "test" {
Expand Down Expand Up @@ -109,3 +138,64 @@ CMD
`
return fmt.Sprintf(s, name, name, privilege)
}

func pipeGrantConfigWithDefaultPrivilege(name string) string {
s := `
resource "snowflake_database" "test" {
name = "%v"
comment = "Terraform acceptance test"
}
resource "snowflake_schema" "test" {
name = snowflake_database.test.name
database = snowflake_database.test.name
comment = "Terraform acceptance test"
}
resource "snowflake_table" "test" {
database = snowflake_database.test.name
schema = snowflake_schema.test.name
name = snowflake_schema.test.name
column {
name = "id"
type = "NUMBER(5,0)"
}
column {
name = "data"
type = "VARCHAR(16)"
}
}
resource "snowflake_role" "test" {
name = "%v"
}
resource "snowflake_stage" "test" {
name = snowflake_schema.test.name
database = snowflake_database.test.name
schema = snowflake_schema.test.name
comment = "Terraform acceptance test"
}
resource "snowflake_pipe_grant" "test" {
pipe_name = snowflake_pipe.test.name
database_name = snowflake_database.test.name
roles = [snowflake_role.test.name]
schema_name = snowflake_schema.test.name
}
resource "snowflake_pipe" "test" {
database = snowflake_database.test.name
schema = snowflake_schema.test.name
name = snowflake_schema.test.name
comment = "Terraform acceptance test"
copy_statement = <<CMD
COPY INTO "${snowflake_table.test.database}"."${snowflake_table.test.schema}"."${snowflake_table.test.name}"
FROM @"${snowflake_stage.test.database}"."${snowflake_stage.test.schema}"."${snowflake_stage.test.name}"
FILE_FORMAT = (TYPE = CSV)
CMD
auto_ingest = false
}
`
return fmt.Sprintf(s, name, name)
}

0 comments on commit e8721f0

Please sign in to comment.