chore: Extract reviewdog job from integration workflow #2027
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Expecting to get message on PR about the file not being `go-fumpt`ed.
|
Integration tests failure for bf66241f0c549880a98967beb07507913dc644b9 |
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
This is the revert of the intentional format change earlier.
sfc-gh-asawicki
changed the title
|
Integration tests success for 367537ed38cd6ef4696eb4cce10355f83c35fa20 |
|
Integration tests failure for be3dd85f263de0e2f4301eef9bd846ed7e302f53 |
|
Integration tests success for be3dd85f263de0e2f4301eef9bd846ed7e302f53 |
sfc-gh-pbosak
approved these changes
Aug 22, 2023
sfc-gh-asawicki
deleted the
extract-reviewdog-job-from-integration-build
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
make lint-cifrom integration workflow.Step
make lint-ci integrationwas wasting over 2 minutes of time of the integration workflow, delaying acceptance tests start (which is the longest part of our build). This should make our builds 2-3 minutes faster.Test Plan