fix: Deleting a snowflake_user and their associated snowlfake_role_grant causes an error #1142
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mwiewior
force-pushed
the
issue-889
branch
3 times, most recently
from
e2aa86b
to
7b3cc25
Compare
|
Hi @sfc-gh-swinkler - could you pls kick off gh actions? |
|
Hi @sfc-gh-jalin maybe you could take a look as well - this is sth that really makes it hard to manage users/roles from Terraform and already a few persons have upvoted this issue as well. Thx! |
|
Hi @mwiewior We plan to take a look at this but we currently have very low bandwidth on the team. |
|
ok, thx - just ping me if can help you somehow |
|
@sfc-gh-jlove hey any chance you will have some time for this one ? |
|
@mwiewior sorry i was on grievance leave. my wife died last month and there wasn't anyone else on the team who could approve PRs. i am catching up now. |
|
/ok-to-test sha=7a986e6 |
sfc-gh-swinkler
approved these changes
Aug 10, 2022
|
thank you for your contribution |
|
Integration tests success for 7a986e6 |
This was referenced Nov 1, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is to fix #889 by checking a Snowflake SQL error code and printing a warning instead of failing in case of non-existing user.
Test Plan
References