Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add missing PrivateLink URLs to datasource #1603

Conversation

dgniewek
Copy link
Contributor

@dgniewek dgniewek commented Mar 6, 2023

Added additional outputs to snowflake_system_get_privatelink_config returned by DB, but not previously included in terraform datasource.

List of additional outputs:

  • regionless_account_url
  • regionless_snowsight_url
  • snowsight_url
  • internal_stage

Test Plan

  • acceptance tests - passed locally, please run at PR level

References

https://docs.snowflake.com/en/sql-reference/functions/system_get_privatelink_config

@dgniewek
Copy link
Contributor Author

@sfc-gh-swinkler may I ask for activating GH actions for this PR pls?

@sfc-gh-swinkler
Copy link
Collaborator

This looks fine, but i cannot find anywhere in the documentation where it says this function returns these values. https://docs.snowflake.com/en/sql-reference/functions/system_get_privatelink_config. If you could please explain where these come from, that would be helpful. In the meantime i will go ahead an merge since it won't cause any problems if the values are not found anyhow.

@sfc-gh-swinkler sfc-gh-swinkler merged commit 78782b1 into Snowflake-Labs:main Mar 23, 2023
@dgniewek
Copy link
Contributor Author

Hi,
Thanks for merging :)

Unfortunately, some of those options seem undocumented but helpful in further terraforming (creation of regionless-privatelink-account-url DNS record for example).

I got those parameters directly from SYSTEM$GET_PRIVATELINK_CONFIG() function output:

{
  "regionless-snowsight-privatelink-url": "app-snoworg-snowacc.privatelink.snowflakecomputing.com",
  "privatelink-account-name": "ab12345.eu-west-1.privatelink",
  "privatelink-internal-stage": "sfc-xxxxx.s3.eu-west-1.amazonaws.com",
  "privatelink-vpce-id": "com.amazonaws.vpce.eu-west-1.vpce-xxxxxxxxxxxxx",
  "snowsight-privatelink-url": "app.eu-west-1.privatelink.snowflakecomputing.com",
  "privatelink-account-url": "ab12345.eu-west-1.privatelink.snowflakecomputing.com",
  "regionless-privatelink-account-url": "snoworg-snowacc.privatelink.snowflakecomputing.com",
  "privatelink_ocsp-url": "ocsp.ab12345.eu-west-1.privatelink.snowflakecomputing.com",
  "privatelink-connection-urls": "[]"
}

@dgniewek dgniewek deleted the feature/add_missing_privatelink_data branch March 24, 2023 06:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants