Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Migrate external tables to new sdk #2006

Merged
merged 24 commits into from
Sep 27, 2023
Merged

feat: Migrate external tables to new sdk #2006

merged 24 commits into from
Sep 27, 2023

Conversation

sfc-gh-jcieslak
Copy link
Collaborator

@sfc-gh-jcieslak sfc-gh-jcieslak commented Aug 10, 2023 •
edited

Test Plan

  • unit tests (SQL generation + validations)
  • integration tests

References

github-actions[bot]
github-actions bot reviewed Aug 10, 2023
View reviewed changes
pkg/sdk/external_tables.go Outdated Show resolved Hide resolved
pkg/sdk/external_tables_integration_test.go Outdated Show resolved Hide resolved
pkg/sdk/external_tables_integration_test.go Show resolved Hide resolved
pkg/sdk/external_tables_integration_test.go Outdated Show resolved Hide resolved
pkg/sdk/external_tables_impl.go Outdated Show resolved Hide resolved
pkg/sdk/external_tables_impl.go Outdated Show resolved Hide resolved
pkg/sdk/external_tables.go Outdated Show resolved Hide resolved
pkg/sdk/external_tables_integration_test.go Outdated Show resolved Hide resolved
pkg/sdk/external_tables_validations.go Outdated Show resolved Hide resolved
@github-actions
Copy link

Integration tests failure for b0963a4c1bab3e1bc181c18c5e9c1e802854e2df

@sfc-gh-jcieslak sfc-gh-jcieslak changed the title Migrate external tables to new sdk (Draft) Migrate external tables to new sdk Aug 11, 2023
@sfc-gh-jcieslak sfc-gh-jcieslak force-pushed the migrate-external-tables-to-new-sdk branch from b0963a4 to ed86a18 Compare August 31, 2023 11:54
@github-actions
Copy link

Integration tests failure for ed86a18420565c5315181524ff46f71808c547ca

@github-actions
Copy link

github-actions bot commented Sep 1, 2023

Integration tests failure for 59bed8a66ef2347b03d3fcabfda1ec6b4ce534d7

github-actions[bot]
github-actions bot reviewed Sep 1, 2023
View reviewed changes
pkg/sdk/external_tables_integration_test.go Outdated Show resolved Hide resolved
pkg/sdk/external_tables_integration_test.go Outdated Show resolved Hide resolved
pkg/sdk/external_tables_integration_test.go Outdated Show resolved Hide resolved
pkg/sdk/external_tables_integration_test.go Outdated Show resolved Hide resolved
pkg/sdk/external_tables_integration_test.go Outdated Show resolved Hide resolved
pkg/sdk/external_tables_integration_test.go Outdated Show resolved Hide resolved
pkg/sdk/external_tables_integration_test.go Outdated Show resolved Hide resolved
pkg/sdk/external_tables_integration_test.go Outdated Show resolved Hide resolved
pkg/sdk/external_tables_integration_test.go Outdated Show resolved Hide resolved
pkg/sdk/external_tables_integration_test.go Outdated Show resolved Hide resolved
@github-actions
Copy link

github-actions bot commented Sep 1, 2023

Integration tests failure for bc4e676979b6383eeb7f4534597458666d0e3192

github-actions[bot]
github-actions bot reviewed Sep 4, 2023
View reviewed changes
pkg/sdk/dto_utils.go Outdated Show resolved Hide resolved
pkg/sdk/dto_utils.go Outdated Show resolved Hide resolved
pkg/sdk/helper_test.go Outdated Show resolved Hide resolved
pkg/sdk/external_tables_test.go Show resolved Hide resolved
pkg/sdk/external_tables_integration_test.go Show resolved Hide resolved
@github-actions
Copy link

github-actions bot commented Sep 4, 2023

Integration tests failure for 82be2346f863cafdd27dac1b2a3ce37d3590a108

@sfc-gh-jcieslak sfc-gh-jcieslak force-pushed the migrate-external-tables-to-new-sdk branch 2 times, most recently from 5984bc2 to 6a82fac Compare September 6, 2023 12:03
github-actions[bot]
github-actions bot reviewed Sep 6, 2023
View reviewed changes
pkg/sdk/external_tables_integration_test.go Outdated Show resolved Hide resolved
pkg/sdk/external_tables_integration_test.go Outdated Show resolved Hide resolved
pkg/sdk/external_tables_dto.go Show resolved Hide resolved
@github-actions
Copy link

github-actions bot commented Sep 6, 2023

Integration tests failure for 5984bc2f5d4836ffee59b883a528bbbf3c3b89a9

@github-actions
Copy link

github-actions bot commented Sep 6, 2023

Integration tests failure for 6a82fac7c840a7e0b0f475c9af704099a338525b

github-actions[bot]
github-actions bot reviewed Sep 6, 2023
View reviewed changes
pkg/sdk/external_tables_impl.go Outdated Show resolved Hide resolved
pkg/sdk/external_tables_impl.go Outdated Show resolved Hide resolved
@sfc-gh-jcieslak sfc-gh-jcieslak force-pushed the migrate-external-tables-to-new-sdk branch from 14b2737 to 73e48e4 Compare September 6, 2023 12:36
@sfc-gh-jcieslak sfc-gh-jcieslak changed the title (Draft) Migrate external tables to new sdk feat: Migrate external tables to new sdk Sep 6, 2023
@github-actions
Copy link

github-actions bot commented Sep 6, 2023

Integration tests failure for 14b273761f618a0f7ac1898299b253d3326f71c0

@github-actions
Copy link

github-actions bot commented Sep 6, 2023

Integration tests failure for 73e48e4105be369df5b4627327ccc4085b26c1ce

github-actions[bot]
github-actions bot reviewed Sep 6, 2023
View reviewed changes
pkg/sdk/external_tables_integration_test.go Outdated Show resolved Hide resolved
pkg/sdk/external_tables_integration_test.go Outdated Show resolved Hide resolved
pkg/sdk/external_tables_integration_test.go Outdated Show resolved Hide resolved
pkg/sdk/external_tables_integration_test.go Outdated Show resolved Hide resolved
@github-actions
Copy link

github-actions bot commented Sep 6, 2023

Integration tests failure for dfa06ab6fd6d78b1c72f9c6404e9e23b3fdbc137

@github-actions
Copy link

github-actions bot commented Sep 7, 2023

Integration tests failure for a0ec7a7d90dd2ae8218c5f9467d32f87222c12b0

@sfc-gh-jcieslak sfc-gh-jcieslak marked this pull request as ready for review September 8, 2023 09:42
sfc-gh-asawicki
sfc-gh-asawicki requested changes Sep 13, 2023
View reviewed changes
pkg/sdk/external_tables_integration_test.go Show resolved Hide resolved
pkg/sdk/errors.go Show resolved Hide resolved
pkg/sdk/validations.go Show resolved Hide resolved
pkg/sdk/external_tables_integration_test.go Show resolved Hide resolved
@github-actions
Copy link

Integration tests failure for 15e9e47fff9b91294117f00234f605252cdb1269

sfc-gh-asawicki
sfc-gh-asawicki requested changes Sep 18, 2023
View reviewed changes
pkg/sdk/external_tables.go Outdated Show resolved Hide resolved
pkg/sdk/poc/generator/poc.go Outdated Show resolved Hide resolved
pkg/sdk/poc/generator/poc_builders.go Outdated Show resolved Hide resolved
@github-actions
Copy link

Integration tests failure for dbae26b8fe222bf4bc0f4a58266a44ece31bda80

@github-actions
Copy link

Integration tests success for dbae26b8fe222bf4bc0f4a58266a44ece31bda80

@sfc-gh-jcieslak sfc-gh-jcieslak merged commit 5af17cf into main Sep 27, 2023
8 checks passed
@sfc-gh-jcieslak sfc-gh-jcieslak deleted the migrate-external-tables-to-new-sdk branch September 27, 2023 13:08
@snowflake-release-please snowflake-release-please bot mentioned this pull request Sep 27, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@github-actions github-actions[bot] github-actions left review comments

@sfc-gh-asawicki sfc-gh-asawicki sfc-gh-asawicki approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@sfc-gh-jcieslak @sfc-gh-asawicki