Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Add Manage Warehouses Account Grant #2017

Merged
merged 4 commits into from
Oct 3, 2023
Merged

feat: Add Manage Warehouses Account Grant #2017

merged 4 commits into from
Oct 3, 2023

Conversation

GtheSheep
Copy link
Contributor

Add MANAGE WAREHOUSES account privilege

Test Plan

  • acceptance tests

References

Snowflake Docs

@GtheSheep GtheSheep changed the title Feat/manage warehouses feat: Add Manage Warehouses Account Grant Aug 17, 2023
@NiallRees
Copy link
Contributor

Hey @scottwinkler - any chance we can get this merged? ty!

@NiallRees
Copy link
Contributor

Hi @sfc-gh-asawicki, @sfc-gh-pbosak - should be an easy approval to get into the next release? 🙏

@ian-whitestone
Copy link

Hey folks, any chance we merge this? A bunch of Snowflake users are asking for this

@sfc-gh-asawicki
Copy link
Collaborator

/ok-to-test sha=d1be2537d555595dcbe2db4e3e667db493f80c05

@github-actions
Copy link

github-actions bot commented Oct 2, 2023

Integration tests failure for d1be2537d555595dcbe2db4e3e667db493f80c05

1 similar comment
@github-actions
Copy link

github-actions bot commented Oct 2, 2023

Integration tests failure for d1be2537d555595dcbe2db4e3e667db493f80c05

@sfc-gh-asawicki
Copy link
Collaborator

LGTM.

@GtheSheep, can you please rebase on the newest main so that we can run integration tests?

@GtheSheep
Copy link
Contributor Author

@sfc-gh-asawicki - updated!

@sfc-gh-asawicki
Copy link
Collaborator

/ok-to-test sha=efff173d14ae726f34735de288ed36b0920932ee

@github-actions
Copy link

github-actions bot commented Oct 2, 2023

Integration tests failure for efff173d14ae726f34735de288ed36b0920932ee

@GtheSheep
Copy link
Contributor Author

@sfc-gh-asawicki - Errors don't seem related to this change? PipeGrants/ PwdPolicy

@github-actions
Copy link

github-actions bot commented Oct 3, 2023

Integration tests failure for efff173d14ae726f34735de288ed36b0920932ee

@sfc-gh-asawicki
Copy link
Collaborator

@GtheSheep, yeah, we will be working on the stability of the tests shortly because, sadly, there are plenty of flaky ones... Let me retry them.

@github-actions
Copy link

github-actions bot commented Oct 3, 2023

Integration tests success for efff173d14ae726f34735de288ed36b0920932ee

@sfc-gh-asawicki
Copy link
Collaborator

/ok-to-test sha=ab9bcdfbf365f2fef709755f4375779503e5d4d0

@github-actions
Copy link

github-actions bot commented Oct 3, 2023

Integration tests success for ab9bcdfbf365f2fef709755f4375779503e5d4d0

@sfc-gh-swinkler
Copy link
Collaborator

LGTM

@sfc-gh-asawicki sfc-gh-asawicki merged commit 89c7148 into Snowflake-Labs:main Oct 3, 2023
7 checks passed
@sfc-gh-asawicki
Copy link
Collaborator

@GtheSheep merged; thanks for your contribution!

@snowflake-release-please snowflake-release-please bot mentioned this pull request Oct 3, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sfc-gh-jcieslak sfc-gh-jcieslak sfc-gh-jcieslak approved these changes

@sfc-gh-asawicki sfc-gh-asawicki sfc-gh-asawicki approved these changes

@sfc-gh-swinkler sfc-gh-swinkler Awaiting requested review from sfc-gh-swinkler

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@GtheSheep @NiallRees @ian-whitestone @sfc-gh-asawicki @sfc-gh-swinkler @sfc-gh-jcieslak