Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Add grant ownership to SDK #2064

Merged
merged 11 commits into from
Sep 26, 2023
Merged

feat: Add grant ownership to SDK #2064

merged 11 commits into from
Sep 26, 2023

Conversation

sfc-gh-asawicki
Copy link
Collaborator

@sfc-gh-asawicki sfc-gh-asawicki commented Sep 21, 2023 •
edited

Changes

  • Implement granting ownership to schema objects in SDK:
    • Add implementation based on references
  • What was NOT changed:
    • Grants interface is still not using our new Requests, new methods are also not using them, to make them consistent inside this interface and not to do too much refactoring in this PR

Test Plan

  • unit tests (sql generation and validations)
  • integration tests (sql invocation)
  • acceptance tests (nothing should break yet)

References

@github-actions
Copy link

Integration tests success for 4d88bc735d5e608a7c54aaf8937db5db0d15f01a

@sfc-gh-asawicki sfc-gh-asawicki marked this pull request as ready for review September 21, 2023 18:49
sfc-gh-swinkler
sfc-gh-swinkler requested changes Sep 21, 2023
View reviewed changes
pkg/sdk/grants.go Outdated Show resolved Hide resolved
pkg/sdk/grants.go Outdated Show resolved Hide resolved
@github-actions
Copy link

Integration tests success for 1766f8cf262e14bb5cfeed32675704fe83ee25ed

@github-actions
Copy link

Integration tests failure for 34560fc3cf491881381d0a27c9eb2fefe5a4dae1

2 similar comments
@github-actions
Copy link

Integration tests failure for 34560fc3cf491881381d0a27c9eb2fefe5a4dae1

@github-actions
Copy link

Integration tests failure for 34560fc3cf491881381d0a27c9eb2fefe5a4dae1

@github-actions
Copy link

Integration tests failure for d8458d5815a2c3f4692984eb292037a23828d6d7

1 similar comment
@github-actions
Copy link

Integration tests failure for d8458d5815a2c3f4692984eb292037a23828d6d7

@github-actions
Copy link

Integration tests success for d8458d5815a2c3f4692984eb292037a23828d6d7

@github-actions
Copy link

Integration tests failure for 2519d260ed0548ac0b3c51d2fc2eefe1877e7e1f

@github-actions
Copy link

Integration tests failure for 2519d260ed0548ac0b3c51d2fc2eefe1877e7e1f

@github-actions
Copy link

Integration tests success for 2519d260ed0548ac0b3c51d2fc2eefe1877e7e1f

@sfc-gh-asawicki sfc-gh-asawicki merged commit f85ec8b into main Sep 26, 2023
8 checks passed
@sfc-gh-asawicki sfc-gh-asawicki deleted the add-grant-ownership-to-sdk branch September 26, 2023 21:05
@snowflake-release-please snowflake-release-please bot mentioned this pull request Sep 26, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sfc-gh-swinkler sfc-gh-swinkler sfc-gh-swinkler approved these changes

@sfc-gh-jcieslak sfc-gh-jcieslak sfc-gh-jcieslak approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@sfc-gh-asawicki @sfc-gh-swinkler @sfc-gh-jcieslak