-
Notifications
You must be signed in to change notification settings - Fork 399
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add session policy to SDK #2088
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sfc-gh-asawicki
commented
Oct 2, 2023
Integration tests success for bc1526a8a4cfbbd8c78e5299c53fb938be47bc17 |
Integration tests failure for 0f7ea0ba04c064f4b403f403dc45c7d9a58894bf |
Integration tests success for 0f7ea0ba04c064f4b403f403dc45c7d9a58894bf |
sfc-gh-jcieslak
previously approved these changes
Oct 2, 2023
Integration tests failure for 954e9386b019c837086c2dd271f130083dd4d40a |
Integration tests success for 954e9386b019c837086c2dd271f130083dd4d40a |
sfc-gh-jcieslak
approved these changes
Oct 3, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
As a part of this implementation, the generator was used (check the
session_policies_def.go
file first). After generation, the following changes were applied:ID()
method to session policy.ShowID()
interface method and implementation (not yet generated).Test Plan
References