-
Notifications
You must be signed in to change notification settings - Fork 399
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add task to SDK #2099
Merged
Merged
feat: Add task to SDK #2099
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Integration tests failure for 42305f5bcaaf892e9cbf81b942ec4fde3a0e2e8e |
Integration tests failure for ecfec6cc445a59cc5b133a6bf82ae81a73f208ac |
Integration tests failure for 3de73fb16f23458723a0d8f073d2fc535ffccbf6 |
Integration tests success for 9b5df272043ce76f81ed1962390c30575a567d4a |
sfc-gh-jcieslak
requested changes
Oct 6, 2023
Integration tests success for 7ce0f7fcdd63b5b633e5e879dec72820040eb772 |
sfc-gh-jcieslak
approved these changes
Oct 9, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
EXECUTE
)validate()
method for common existing types)Assignment
andOptionalAssignment
)The generator was used as part of this implementation (check the
tasks_def.go
file first). After generation, the following changes were applied:convert()
Describe
asShowByID
(because returned structures are the same)taskDBRow
tosql.NullString
(all nullable + all the ones that are not a part of SHOW TERSE output)taskDBRow
Create
and forShow
Alter
testsall options
test fromDrop
andDescribe
ID()
method toTask
AllowOverlappingExecution
tobool
after consideration (still string in def)id
fromTestTasks_Show
Test Plan
References