Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Add task clone to sdk #2105

Merged
merged 2 commits into from
Oct 10, 2023
Merged

feat: Add task clone to sdk #2105

merged 2 commits into from
Oct 10, 2023

Conversation

sfc-gh-asawicki
Copy link
Collaborator

@sfc-gh-asawicki sfc-gh-asawicki commented Oct 9, 2023 •
edited

Changes

  • Add task clone to SDK:
    • Add implementation based on references
    • Update task definition in tasks_def.go

Test Plan

  • unit tests (SQL generation and validations)
  • integration tests (SQL invocation)
  • acceptance tests (nothing should break yet)

References

@sfc-gh-asawicki sfc-gh-asawicki changed the title Add task clone to sdk feat: Add task clone to sdk Oct 9, 2023
@github-actions
Copy link

github-actions bot commented Oct 9, 2023

Integration tests failure for 280a67e62be4fc68777652543fbafb48d2c46661

@sfc-gh-asawicki sfc-gh-asawicki marked this pull request as ready for review October 9, 2023 12:50
@github-actions
Copy link

github-actions bot commented Oct 9, 2023

Integration tests failure for 280a67e62be4fc68777652543fbafb48d2c46661

2 similar comments
@github-actions
Copy link

github-actions bot commented Oct 9, 2023

Integration tests failure for 280a67e62be4fc68777652543fbafb48d2c46661

@github-actions
Copy link

github-actions bot commented Oct 9, 2023

Integration tests failure for 280a67e62be4fc68777652543fbafb48d2c46661

@github-actions
Copy link

Integration tests success for 280a67e62be4fc68777652543fbafb48d2c46661

@sfc-gh-asawicki sfc-gh-asawicki merged commit acddb2c into main Oct 10, 2023
11 of 12 checks passed
@sfc-gh-asawicki sfc-gh-asawicki deleted the add-task-clone-to-sdk branch October 10, 2023 06:58
@snowflake-release-please snowflake-release-please bot mentioned this pull request Oct 9, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sfc-gh-jcieslak sfc-gh-jcieslak sfc-gh-jcieslak approved these changes

@sfc-gh-swinkler sfc-gh-swinkler Awaiting requested review from sfc-gh-swinkler

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@sfc-gh-asawicki @sfc-gh-jcieslak