Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Integration tests setup db once #2118

Merged
merged 5 commits into from
Oct 13, 2023

Conversation

sfc-gh-asawicki
Copy link
Collaborator

@sfc-gh-asawicki sfc-gh-asawicki commented Oct 12, 2023

After moving integration tests to a separate package in #2111 and #2115, it is possible now to reuse a common setup. This PR is about setting up a database only once for all integration tests and cleaning it up at the end.

Changes

  • Create a database in integration tests setup; clean it up in cleanup.
  • Not every test uses the created database (database tests, renames, and tests specifically needing two databases are still creating their own database).
  • Database id is the same string with added UUID so that different test runs do not interfere with each other.

@github-actions
Copy link

Integration tests success for deb0145ceb34b423a6bb3ecb3cd508c48e07f38c

@github-actions
Copy link

Integration tests success for 49dccd9ef6a6df00f1032289718a3ad8b2d131de

@sfc-gh-asawicki sfc-gh-asawicki marked this pull request as ready for review October 12, 2023 16:23
@sfc-gh-asawicki sfc-gh-asawicki merged commit f533368 into main Oct 13, 2023
10 checks passed
@sfc-gh-asawicki sfc-gh-asawicki deleted the integration-tests-setup-db-once branch October 13, 2023 11:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants