Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: Set up schema once for integration tests #2121

Merged
merged 9 commits into from
Oct 18, 2023
Merged

chore: Set up schema once for integration tests #2121

merged 9 commits into from
Oct 18, 2023

Conversation

sfc-gh-asawicki
Copy link
Collaborator

@sfc-gh-asawicki sfc-gh-asawicki commented Oct 13, 2023 •
edited

Introduce a common schema for the SDK integration tests.

Changes

  • Introduced common schema in the same way that the database was introduced
  • Added cleanups that reset the db/schema context
    • Earlier it was done "automatically" by always creating db/schema inside a test or the set of tests. Now we have to ensure going back to the right context. I will create an issue for this contextuality of our integration tests because I am not sure if we should keep the context there, or rather have it always cleared out.

@github-actions
Copy link

Integration tests failure for 1df0ca6ebd95095e9a8dc80ae5447810f8cc12b9

1 similar comment
@github-actions
Copy link

Integration tests failure for 1df0ca6ebd95095e9a8dc80ae5447810f8cc12b9

@sfc-gh-asawicki sfc-gh-asawicki force-pushed the integration-tests-set-up-schema-once branch from 1df0ca6 to 0c423b3 Compare October 17, 2023 10:21
@github-actions
Copy link

Integration tests failure for 0c423b3fd98d9784bc04bf48b3f13e7b2b237013

@github-actions
Copy link

Integration tests failure for 97d099a24f460ac468df126065b54bf77c43945d

@github-actions
Copy link

Integration tests failure for ee4c3808531cf52912523f971dcabeb1a9b590b5

@github-actions
Copy link

Integration tests failure for e119fab78330fb51de1a508540742945440619e8

@github-actions
Copy link

Integration tests success for 7d7a5ec638087f16ca36ffcc16024f78aa8b8907

@sfc-gh-asawicki sfc-gh-asawicki marked this pull request as ready for review October 18, 2023 08:16
@sfc-gh-asawicki sfc-gh-asawicki merged commit 5e3ebf4 into main Oct 18, 2023
10 checks passed
@sfc-gh-asawicki sfc-gh-asawicki deleted the integration-tests-set-up-schema-once branch October 18, 2023 13:09
@snowflake-release-please snowflake-release-please bot mentioned this pull request Oct 18, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@github-actions github-actions[bot] github-actions left review comments

@sfc-gh-jcieslak sfc-gh-jcieslak sfc-gh-jcieslak approved these changes

@sfc-gh-swinkler sfc-gh-swinkler Awaiting requested review from sfc-gh-swinkler

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@sfc-gh-asawicki @sfc-gh-jcieslak