feat: Provider config refactor #2126
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sfc-gh-swinkler
changed the title
|
Integration tests success for 929707f061f83edbe60ff8ef9dac156d06b78456 |
|
Integration tests failure for f4b291e90574df2e3ab99d45ec10dd5b87b3b81c |
sfc-gh-jcieslak
requested changes
Oct 16, 2023
…ke-Labs/terraform-provider-snowflake into provider-config-refactor
…ke-Labs/terraform-provider-snowflake into provider-config-refactor
|
Integration tests success for 1f7503bae4d82ebf48c9fe2f64451037ac1e3f8a |
|
Integration tests failure for 992b6fd8ee1828d7fc4055488f91950c74d0d170 |
|
Integration tests failure for 66a2470cd93cd55d0cecef4d56256ca2e2d5e6f6 |
sfc-gh-jcieslak
previously approved these changes
Oct 16, 2023
sfc-gh-asawicki
requested changes
Oct 16, 2023
|
Integration tests success for 24ccb84638c4194b5be1817ae29a03d388c1853e |
sfc-gh-asawicki
approved these changes
Oct 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds all missing attributes as per config block of gosnowflake package. https://pkg.go.dev/github.com/snowflakedb/gosnowflake#Config
Renames any attributes which didn't follow convention. Cleaned up oauth logic. Removed pointless tests.