Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: Split existing alter operations #2156

Merged
merged 4 commits into from Oct 30, 2023
Merged

chore: Split existing alter operations #2156

merged 4 commits into from Oct 30, 2023

Conversation

sfc-gh-asawicki
Copy link
Collaborator

@sfc-gh-asawicki sfc-gh-asawicki commented Oct 25, 2023 •
edited

Split existing alter operations to be more consistent with the docs.

Changes

  • Extracted SetTag and UnsetTag from Set/Unset structs
  • Adjusted validations and tests
  • Fixed warehouse validation to check each possible param
  • Removed unsetting a warehouse size; based on docs - also our current resource implementation has been using set for warehouse size correctly already

@sfc-gh-asawicki sfc-gh-asawicki changed the title Chore: Split existing alter operations chore: Split existing alter operations Oct 25, 2023
@github-actions
Copy link

Integration tests failure for 526596a656e92a30e6c41eab5252fd1e75ca50d3

@sfc-gh-asawicki sfc-gh-asawicki marked this pull request as ready for review October 30, 2023 10:51
@github-actions
Copy link

Integration tests failure for 9949ff6302c67ed9c28966e902adca93b0f8bdcc

Base automatically changed from using-tasks-from-sdk-followup to main October 30, 2023 12:34
@github-actions
Copy link

Integration tests failure for 7fee820353f20d5ee03db352a79c6131c1f50b6f

@github-actions
Copy link

Integration tests success for 7fee820353f20d5ee03db352a79c6131c1f50b6f

sfc-gh-jcieslak
sfc-gh-jcieslak reviewed Oct 30, 2023
View reviewed changes
pkg/sdk/schemas.go Outdated Show resolved Hide resolved
pkg/sdk/schemas.go Outdated Show resolved Hide resolved
pkg/sdk/shares.go Outdated Show resolved Hide resolved
pkg/sdk/warehouses.go Outdated Show resolved Hide resolved
pkg/sdk/warehouses.go Outdated Show resolved Hide resolved
@github-actions
Copy link

Integration tests failure for bf0918dd434d90ba0e447240e8af8f11382e6f37

@github-actions
Copy link

Integration tests failure for 592c7f84c94192457f152fc821e5f81008c834ce

@github-actions
Copy link

Integration tests success for 592c7f84c94192457f152fc821e5f81008c834ce

@sfc-gh-asawicki sfc-gh-asawicki merged commit dbb7c91 into main Oct 30, 2023
8 checks passed
@sfc-gh-asawicki sfc-gh-asawicki deleted the split-existing-alter-operations branch October 30, 2023 16:30
@snowflake-release-please snowflake-release-please bot mentioned this pull request Oct 30, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sfc-gh-jcieslak sfc-gh-jcieslak sfc-gh-jcieslak approved these changes

@sfc-gh-swinkler sfc-gh-swinkler Awaiting requested review from sfc-gh-swinkler

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@sfc-gh-asawicki @sfc-gh-jcieslak