chore: Reference IDs of share objects in share.go error messages. #2270
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Without this, we get error messages like ``` Error: error reading share err = [errors.go:17] object does not exist or not authorized ``` that are nearly impossible to debug.
|
Hey @originalrkk. Thanks for the PR. For me, it's fine to add such additional info. Out of curiosity: did you try running the provider with TF_LOG set to DEBUG or TRACE? You get a lot more info that way. |
sfc-gh-asawicki
changed the title
|
Ah, d'oh, good idea. Still think it's useful to have these since ideally we'd only have to fall back to debug for the most pathological / confusing cases. |
sfc-gh-jcieslak
approved these changes
Dec 19, 2023
|
/ok-to-test sha=514200e8112e8b93a412fe46ede61cefc59c6c62 |
|
Integration tests failure for 514200e8112e8b93a412fe46ede61cefc59c6c62 |
sfc-gh-asawicki
approved these changes
Dec 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Without this, we get error messages like
that are nearly impossible to debug.
Test Plan
This PR only adds extra information to error messages.