[fix] escape some strings in query builders #231
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #231 +/- ##
=======================================
Coverage 62.16% 62.16%
=======================================
Files 50 50
Lines 3698 3698
=======================================
Hits 2299 2299
Misses 1097 1097
Partials 302 302
Continue to review full report at Codecov.
|
edulop91
reviewed
Jul 30, 2020
| @@ -120,12 +120,12 @@ func (sb *SchemaBuilder) Swap(targetSchema string) string { | |||
|
|
|||
| // ChangeComment returns the SQL query that will update the comment on the schema. | |||
| func (sb *SchemaBuilder) ChangeComment(c string) string { | |||
| return fmt.Sprintf(`ALTER SCHEMA %v SET COMMENT = '%v'`, sb.QualifiedName(), c) | |||
| return fmt.Sprintf(`ALTER SCHEMA %v SET COMMENT = '%v'`, sb.QualifiedName(), EscapeString(c)) | |||
There was a problem hiding this comment.
why is the other QualifiedName escaped (in RemoveComment) but not this one? I can't really tell if there is a difference or not.
There was a problem hiding this comment.
Good catch. I think qualified names should not be escaped. Or, at least, I wasn't trying to do that in this PR.
edulop91
reviewed
Jul 30, 2020
| @@ -139,7 +139,7 @@ func (vb *ViewBuilder) Unsecure() string { | |||
| // Note that comment is the only parameter, if more are released this should be | |||
| // abstracted as per the generic builder. | |||
| func (vb *ViewBuilder) ChangeComment(c string) string { | |||
| return fmt.Sprintf(`ALTER VIEW %v SET COMMENT = '%v'`, vb.QualifiedName(), c) | |||
| return fmt.Sprintf(`ALTER VIEW %v SET COMMENT = '%v'`, vb.QualifiedName(), EscapeString(c)) | |||
edulop91
approved these changes
Jul 30, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Escape comments and other string fields that are not currently escaped in our query builders.
Test Plan
References