Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chrisk/fix task tests #241

Merged
merged 4 commits into from
Aug 11, 2020

Conversation

chriskuchin
Copy link
Contributor

@chriskuchin chriskuchin commented Aug 11, 2020

Snowflake recently made a change that will error if you try to activate a task without a schedule or predecessor. This fixes our test that was doing exactly this.

Test Plan

  • Task Acceptance Tests pass

@ryanking This should fix that test

@chriskuchin chriskuchin requested a review from a team as a code owner August 11, 2020 16:02
@chriskuchin chriskuchin requested review from ryanking and removed request for a team August 11, 2020 16:02
@chriskuchin
Copy link
Contributor Author

@ryanking the tests failed however it seems to have been a configuration error rather than the bad snowflake it was before

Copy link
Contributor

@ryanking ryanking left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@ryanking ryanking merged commit 97d9a47 into Snowflake-Labs:master Aug 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants