Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add data source for SYSTEM$GET_PRIVATELINK_CONFIG() function #545

Merged
merged 3 commits into from
May 17, 2021

Conversation

robbruce
Copy link
Contributor

Test Plan

  • acceptance tests
  • - This executes SELECT SYSTEM$GET_PRIVATELINK_CONFIG(), which applies for accounts with Business Critical plan; although values are returned from Snowflake either way.

Tests ran

$ TF_ACC=1 go test -v ./... -run TestAccSystemGetPrivateLinkConfig_aws
?   	github.com/chanzuckerberg/terraform-provider-snowflake	[no test files]
=== RUN   TestAccSystemGetPrivateLinkConfig_aws
=== PAUSE TestAccSystemGetPrivateLinkConfig_aws
=== CONT  TestAccSystemGetPrivateLinkConfig_aws
--- PASS: TestAccSystemGetPrivateLinkConfig_aws (5.92s)
PASS
ok  	github.com/chanzuckerberg/terraform-provider-snowflake/pkg/datasources	6.353s
?   	github.com/chanzuckerberg/terraform-provider-snowflake/pkg/db	[no test files]
testing: warning: no tests to run
PASS
ok  	github.com/chanzuckerberg/terraform-provider-snowflake/pkg/provider	(cached) [no tests to run]
testing: warning: no tests to run
PASS
ok  	github.com/chanzuckerberg/terraform-provider-snowflake/pkg/resources	(cached) [no tests to run]
testing: warning: no tests to run
PASS
ok  	github.com/chanzuckerberg/terraform-provider-snowflake/pkg/snowflake	(cached) [no tests to run]
?   	github.com/chanzuckerberg/terraform-provider-snowflake/pkg/testhelpers	[no test files]
testing: warning: no tests to run
PASS
ok  	github.com/chanzuckerberg/terraform-provider-snowflake/pkg/validation	(cached) [no tests to run]
?   	github.com/chanzuckerberg/terraform-provider-snowflake/pkg/version	[no test files]

The JSON structure from the function SELECT SYSTEM$GET_PRIVATELINK_CONFIG() on all the accounts I have ran against are AWS, so have not been able to verify if there are any different behaviours on Azure, e.g. the config value privatelink-ocsp-url may actually come back as documented rather than privatelink_ocsp-url so have added belt-n-braces around that.

References

@robbruce robbruce requested a review from a team as a code owner May 17, 2021 14:28
@robbruce robbruce requested a review from alldoami May 17, 2021 14:28
@alldoami
Copy link
Contributor

/ok-to-test sha=563760c

@github-actions
Copy link

Integration tests success for 563760c

@alldoami
Copy link
Contributor

@robbruce could you update your branch? After that we can merge! Thank you for creating this!

@robbruce
Copy link
Contributor Author

@alldoami - merged with main

@alldoami
Copy link
Contributor

/ok-to-test sha=2f41868

Copy link
Contributor

@alldoami alldoami left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@github-actions
Copy link

Integration tests success for 2f41868

@alldoami alldoami merged commit e860561 into Snowflake-Labs:main May 17, 2021
@robbruce robbruce deleted the f/private_link branch May 18, 2021 07:36
anton-chekanov pushed a commit to anton-chekanov/terraform-provider-snowflake that referenced this pull request Jan 25, 2022
daniepett pushed a commit to daniepett/terraform-provider-snowflake that referenced this pull request Feb 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants