Fix tests/lint build errors #2
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Snugug
requested changes
Apr 19, 2017
tests/args.js
Outdated
| @@ -8,7 +8,7 @@ test('Bad Slug', t => { | |||
| return args().then(() => { | |||
| t.fail('Should Not Pass'); | |||
| }).catch(e => { | |||
| t.is(e.message, 'REPO_SLUG needs to contain user and repo name (e.g. \'snugug/reparo\'). Set to \'snugug\''); | |||
| t.is(e.message, 'Repository Slug needs to contain user and repo name (e.g. \'snugug/reparo\'). Set to \'snugug\''); | |||
There was a problem hiding this comment.
Tests don't pass with the mismatching messages. Should I change back this and also update the message within ./lib/args.js as well?
|
@Snugug please review changes. Tests do not pass without matching messages in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #1