Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SoCo 0.22.0 fails to install on some platforms due to requirement to build 'yarl' and 'mutlidict' #819

Closed
pwt opened this issue Apr 17, 2021 · 4 comments · Fixed by #821
Closed
Assignees

Comments

@pwt
Copy link
Contributor

pwt commented Apr 17, 2021

The inclusion of events_asyncio in v0.22.0 brought in a dependency on the aiohttp package, which in turn depends on yarl and multidict.

It turns out that both yarl and multidict have binary wheels, with prebuilt versions available for some platforms (Linux, macOS, Windows), meaning that installs on these platforms will work without error.

However, build/installation failures can occur on other platforms, including on Raspberry PIs running PiOS (Raspbian). In order to install successfully, the build-essential (compiler, etc.) and python3-dev (Python headers) packages must be present:

sudo apt install build-essential python3-dev

These new dependencies may also cause install failures on other platforms.

We need to determine whether this is going to be a major problem, and look for workarounds.

@pwt pwt self-assigned this Apr 17, 2021
@pwt pwt linked a pull request Apr 17, 2021 that will close this issue
@pwt
Copy link
Contributor Author

pwt commented Apr 17, 2021

@bdraco : Do you have any thoughts on this? I'm worried that the inclusion of the new aiohttp dependency is going to prevent SoCo installs on some platforms.

@bdraco
Copy link
Contributor

bdraco commented Apr 17, 2021

How about making it an extra? so you can do something like

pip install 'SoCo[asyncio]'

extras_require = {
'asyncio': ['aiohttp']
}

Typing this on a mobile so hopefully it makes sense.

@bdraco
Copy link
Contributor

bdraco commented Apr 17, 2021

Also FWITW, both yarl and multidict have pure python install options and can be installed as follows:

MULTIDICT_NO_EXTENSIONS=1 pip install multidict
YARL_NO_EXTENSIONS=1 pip install yarl

I think the extra route is the safer one though

@pwt pwt linked a pull request Apr 17, 2021 that will close this issue
@pwt
Copy link
Contributor Author

pwt commented Apr 17, 2021

Great -- thanks @bdraco.

I'll have a play with removing the hard requirement, and the extras_require approach.

@pwt pwt closed this as completed in #821 Apr 17, 2021
pwt added a commit that referenced this issue Apr 17, 2021
- Remove 'aiohttp' from requirements
- Insert import error message in events_asyncio.py
- Add extras_require in setup.py for events_asyncio: aiohttp
pwt added a commit that referenced this issue Apr 17, 2021
- Remove 'aiohttp' from requirements
- Insert import error message in events_asyncio.py
- Add extras_require in setup.py for events_asyncio: aiohttp
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants