Paint soco black #706
Merged
Paint soco black #706
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Ok. I need to wrestly with TravisCI a little more to get that to work (it is hard to test on my own computer). But the core of the PR is the same. |
KennethNielsen
force-pushed
the
paint_soco_black
branch
from
d587e6c
to
a39faf9
Compare
|
Well, it only took 7 attempts ... but now the black checks on TravisCI are restricted to the Python versions that can run it. But now there is a functioning black check that will be executed when the pull request is made to check whether code was run through black. Comments? |
|
LGTM. Unit and integration tests are passing on my system (macOS, Python 3.7.7). |
|
I will start with merging this, thus probably breaking all other PR's in the progress. I will help with the rebasing as needed. |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Yeah. There is finally a PR to paint SoCo black.
black is "the uncomprimising code formatter" (https://github.com/psf/black) and its sole purpose is to format all code into a consistent style. black is uncompromising, in that it allows very little customization, but personally I find that I much prefer to have a codestyle tool that can't be modified, to debating which style is best. From my perspective, codestyle consistency is a hell of a lot more important that the itty bitty details of the style.
But perhaps the biggest advantage of black is that it almost removes code style discussions from reviews. I set it up so that there is a travisCI check that checks that the branch is black formatted. As those of that have gone through a review with me will know, I do care about style, but implementing it this way will remove the need to comment on codestyle to the point where I can just refer to the tool.
I painted both soco, the examples and the tests black. As an added advantage to this, black formatting the test code brought it within an hours of work to make it pass linting as well, which means that we now have linted test code as well 🤸♂️
Since this is code formatting, it touches just about all lines of code, which means that all other PRs will break, but I will help with that.
Let me know what you think.