New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add 'trueplay' property to SoCo #775
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pwt
force-pushed
the
add_trueplay_property
branch
from
December 9, 2020 12:02
5d2dfdd
to
75b479e
Compare
pwt
force-pushed
the
add_trueplay_property
branch
from
December 12, 2020 21:02
5131fbf
to
66e4794
Compare
pwt
force-pushed
the
add_trueplay_property
branch
from
December 15, 2020 10:00
66e4794
to
9e4b574
Compare
Works fine on a trueplay tuned beam, changing the value reflects immediately to the settings in the mobile app. The |
rytilahti
reviewed
Dec 26, 2020
Passes all check jobs locally, and has been independently tested, so I'm going to merge this. |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a gettable/settable property
trueplay
, with accompanying tests. The property allows the Trueplay state of a speaker (True
orFalse
) to be determined, and to be changed.Devices that do not support Trueplay, or which do not have a current Trueplay calibration, will return
None
on getting the property, and raise aNotSupportedException
when setting the property. Can only be set on visible devices. Attempting to set on non-visible devices will raise aSoCoNotVisibleException
.Tested on S1 and S2 devices, devices that don't support Trueplay, and devices that do support Trueplay, with and without a current calibration profile.