New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add SoCo method to determine HDMI/Optical input audio format #832
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This returns a string representation of the currently active audio input format.
pwt
reviewed
Jul 6, 2021
rytilahti
changed the title
WIP: Add soundbar_audio_input_format
Add soundbar_audio_input_format{_code} to access toslink/hdmi input format
Jul 7, 2021
Added some tests & did some fine tuning. @pwt please let me know if there's some other changes that are still needed to get this merged! |
pwt
reviewed
Oct 11, 2021
pwt
changed the title
Add soundbar_audio_input_format{_code} to access toslink/hdmi input format
Add SoCo method to determine HDMI/Optical input audio format
Oct 11, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is extracted from #780 to avoid overloading that PR with multiple different features.
This PR adds two new properties to the device to report the audio input format (e.g., if there is no input and whether the input is dolby digital 5.1 or just PCM stereo) for toslink/hdmi input found on soundbars:
soundbar_audio_input_format_code
to return the audio input format as reported by the device, andsoundbar_audio_input_format
to return a human-readable description of the format, if available.I'm not completely happy about this: