Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Explicitly set default timeouts for remaining requests calls #925

Merged
merged 2 commits into from Oct 22, 2022

Conversation

jjlawren
Copy link
Contributor

Explicitly add the timeout parameter to the remaining requests calls.

A current bump to pylint (which is not currently pinned) added this check which is making CI runs fail.

@pwt
Copy link
Contributor

pwt commented Oct 21, 2022

The change to tests/test_soap.py breaks the test for me when running it locally. Try running: pytest -k test_call ..

I'll start looking at getting the check jobs functioning again.

@pwt
Copy link
Contributor

pwt commented Oct 21, 2022

Hi @jjlawren: can you pull in the changes from the current master and massage the conflicts in soco/music_services/accounts.py and soco/soap.py where I've temporarily added the pylint: disable= comments.

Then, let's see if the check jobs run successfully, because the test_call test is still failing for me locally.

@pwt pwt self-assigned this Oct 21, 2022
@pwt pwt added this to the v0.29.0 milestone Oct 22, 2022
@pwt pwt merged commit 71f9ec0 into SoCo:master Oct 22, 2022
@jjlawren jjlawren deleted the fix/pylint_requests_timeout branch October 22, 2022 20:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants