Allow timeout to be specified on soco.play_uri #961
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Cache ZoneGroupState while subscriptions are active
Allow timeout to be specified
…into play_uri_timeout
|
I may have the wrong base for this, I think I started with 0.30 fixes, let me know if I need to do something to fix |
It looks fine to me. There's a couple of unrelated new Pylint warnings, which I'll address separately. |
pwt
pushed a commit
that referenced
this pull request
Apr 14, 2024
- Add kwargs to play_uri() - Add kwargs to play() - Add test
|
This change is now included in SoCo |
|
Glad to help. Thanks for the quick turn around! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow a per call timeout to be set on soco.play_uri - similar to to the existing capability in add_uri_to_queue and add_to_queue.
This capability is needed downstream by the Home Assistant Sonos integration, to allow a longer timeout to be used than the configured default timeout.
home-assistant/core#114936