Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PlaygroundModule is not an NgModule #14

Closed
isaacplmann opened this issue Feb 27, 2017 · 2 comments
Closed

PlaygroundModule is not an NgModule #14

isaacplmann opened this issue Feb 27, 2017 · 2 comments
Assignees

Comments

@isaacplmann
Copy link
Contributor

When I run angular-playground, the first build always fails with a message "PlaygroundModule is not an NgModule". If I save any file, webpack rebuilds successfully.

This is a minor annoyance when running angular-playground because it automatically triggers a rebuild. When you run with -no-serve and manually run with ng serve -a playground you have to know to save a file manually in order to make it build. This could confuse new users.

@jschwarty
Copy link
Contributor

jschwarty commented Feb 27, 2017 via email

@jschwarty jschwarty self-assigned this Mar 1, 2017
@jschwarty
Copy link
Contributor

Looks like this is due to the fact that the Angular CLI code (probably @ngtools/webpack more specifically) is reflecting on the bootstrap code and the entry module and trying to "reflect" through the TypeScript code. The Playground app code is transpiled before publish, so it is delivered on npm install as JavaScript. We can fix this by delivering the TS files for the app folder code of Playground.

lurock pushed a commit that referenced this issue Jan 13, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants