This repository has been archived by the owner on Feb 10, 2023. It is now read-only.
Use ISO 639-2 language code and pass language settings to VLC #189
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SoMuchForSubtlety
approved these changes
Oct 12, 2021
|
I'll probably create a new release once #188 is also done. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #187
There are two changes in this PR:
As described in the linked issue, the default config uses
enas the English-language code, when the 3-letter ISO 639-2 code is what's actually provided by F1TV. This leads to MPV choosing the default language for the stream instead. This PR changes the default config to useengand overrides configs that use 2-letter ISO 639-1 codes.The second change is to make the default VLC command use the user's preferred language. This doesn't seem to work for the
fxtrack, might be that VLC is validating whether it's a real ISO code.Tested these changes by verifying that MPV and VLC both stream in the correct language whether the short or long code is used. Tried this on streams that have English as the default (like most F1TV streams) and streams that have German as the default (as described in the linked issue). Also verified that the
fxaudio track isn't broken in MPV by this change.