This repository has been archived by the owner on Apr 14, 2023. It is now read-only.
1 code splitting #1
Open
SoYoung210
wants to merge
8
commits into
master
Choose a base branch
from
1-code-splitting
base: master
Could not load branches
Branch not found: {{ refName }}
Could not load tags
Nothing to show
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SoYoung210
commented
Oct 10, 2019
client/package.json
Outdated
@@ -14,6 +15,7 @@ | |||
"redux": "4.0.1", | |||
"redux-actions": "2.6.5", | |||
"redux-observable": "1.1.0", | |||
"rxjs": "^6.5.3", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
master브랜치에 rxjs가 빠져있어서 추가했습니다. Code Splitting과는 무관한 작업입니다.
Closed
Open
SoYoung210
force-pushed
the
1-code-splitting
branch
2 times, most recently
from
November 2, 2019 13:12
56dd3ad
to
0e888a4
Compare
SoYoung210
force-pushed
the
master
branch
3 times, most recently
from
November 2, 2019 14:04
8ec8a37
to
37d13ec
Compare
SoYoung210
force-pushed
the
1-code-splitting
branch
from
November 4, 2019 11:03
6c63501
to
cc022f9
Compare
SoYoung210
force-pushed
the
1-code-splitting
branch
from
November 4, 2019 11:17
cc022f9
to
f0d776a
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Desc
master의 기본 프로젝트에서 Code Splitting을 적용했습니다.
@loadable/component 를 이용했습니다.
Result
하이라이팅 된 부분을 보면, script tag에 chunk된 js가 포함되어 있는 것을 볼 수 있습니다.
이는 html-webpack-plugin을 이용했으며,
.html
파일 대신.pug
를 사용하고 있기 때문에 html-webpack-pug-plugin을 추가했습니다.