Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CTM Does not work for Dyeable / Carpet Blocks #8

Open
ApexModder opened this issue Sep 1, 2022 · 3 comments
Open

CTM Does not work for Dyeable / Carpet Blocks #8

ApexModder opened this issue Sep 1, 2022 · 3 comments
Labels
1.20.1 Minecraft 1.20.1 bug Something isn't working core Related to XyCraft Core planned This issue will be handled soon.

Comments

@ApexModder
Copy link

ApexModder commented Sep 1, 2022

CTM does not work for Dyeable (texture layering) or Carpet (None Full Cube Models) Blocks.

Dyeable could be fixed by allowing CTM models to have multiple textures and layering them ontop of each other.
This would split up the tint indices into individual textures, allowing the user to specify which texture gets the Dyed Color applied to it.

None Full Cube Models should be working as far as I know, as I am still parenting the vanilla minecraft:block/carpet model, which handles all the shapes & cubes of the model.
Although this sounds like it requires a PR into Forge for this to function correctly.

Screenshots

Issue

Carpets using full block model
Dyeable blocks having dyed portion transparent, as nothing is applied to that texture slot

This is how the models / blocks are intended to look and connect for our mod.

Intended

Screenshot taken on 1.18.2, using CTM Mod, due to there not being any CTM lib for 1.19.2 other than XyCraft:Core*

Specs

  • OS: Windows 10
  • Minecraft: 1.19.2
  • Forge: 43.1.0
  • XyCraft-Core: 0.5.2
@ApexModder ApexModder added the bug Something isn't working label Sep 1, 2022
@Soaryn Soaryn added core Related to XyCraft Core planned This issue will be handled soon. labels Sep 1, 2022
ApexModder added a commit to ApexStudios-Dev/FantasyFurniture-Archive that referenced this issue Sep 1, 2022
Brings in CTM for our wool & carpet blocks, when XyCraft: Core is installed

This is currently awaiting a Forge PR & XyCraft issue [_ Soaryn/XyCraftTracker#8 _].
Allowing texture layering and different sized block models to function as intended.
@ApexModder
Copy link
Author

ApexModder commented Nov 23, 2022

I noticed that MinecraftForge/MinecraftForge#9065 was finally merged, loaded it up to see if it fixed this issue but alas it has not 😞

Have I been wrong in thinking the issue was entirely on Forges end? will this also require an update to XyCraft: Core in order to be fixed?

Preview

Running on the latest Forge [43.1.57] & XyCraft: Core [0.5.17] versions

image


If it helps at all this is how my carpet ctm models are written

{
  "loader": "xycraft_core:connected_textures",
  "connection_handler": "same_block",
  
  "parent": "minecraft:block/carpet",
  "render_type": "minecraft:cutout",
  
  "textures": {
    "wool": "fantasyfurniture:block/nordic/wool",
    "base": "fantasyfurniture:block/nordic/wool_xyctm",
    "texture_connected": "fantasyfurniture:block/nordic/wool_xyctm_borders",
  
    "particle": "#base",
    "texture_single": "#wool"
  }
}

@nikita488
Copy link

The full-block CTM models was always on XyCraft side, because right now it generates 16x16x16 faces and each is divided into 4 quadrants internally. PR fixed the issue with Composite models, so now you can have as many layers with connected textures as you want on one model, or combined models like: first layer as cube with cloud animation, and second layer with ctm texture without hacks that currently XyCraft use for 2-layered models.
Support for non-full block models still needs to be added to XyCraft.

@Soaryn
Copy link
Owner

Soaryn commented Jun 6, 2023

Connected Textures v2. Pushed to 1.20.

@Soaryn Soaryn added the 1.20.1 Minecraft 1.20.1 label Jun 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
1.20.1 Minecraft 1.20.1 bug Something isn't working core Related to XyCraft Core planned This issue will be handled soon.
Projects
None yet
Development

No branches or pull requests

3 participants