Première passe pour la génération dynamique de components #578
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## manu/parseXMLtoJSON #578 +/- ##
=======================================================
+ Coverage 73.68% 74.71% +1.02%
=======================================================
Files 122 136 +14
Lines 1239 1380 +141
Branches 189 204 +15
=======================================================
+ Hits 913 1031 +118
- Misses 288 309 +21
- Partials 38 40 +2
Continue to review full report at Codecov.
|
|
un lien vers les definitions qui permet de mieux comprendre comment les contenu sont organisés https://www.data.gouv.fr/fr/datasets/r/d1b0f744-c997-48d2-9ec4-1c64e82202d6 |
UnbearableBear
force-pushed
the
manu/jsontocomponents
branch
from
bad9fc4
to
7436ade
Compare
|
😍 Clean code 👍 Je n'ai juste pas compris ce qu'était Pour les variables CSS, ce serait compliqué de les déplacer dans le package css ? |
|
tout ça :)
|
|
Ce serait pas plus "idiomatique" d'avoir un composant |
|
Yes j'ai hésité un petit bout de temps et comme c'était récursif je me suis dit qu'un component récursif c'est pas commun donc je vais juste faire une fonction mais, effectivement, ça fait bizarre au final |
Yes mais je le fais dans une PR à part juste après alors ? |
UnbearableBear
force-pushed
the
manu/jsontocomponents
branch
3 times, most recently
from
c225813
to
a33ab20
Compare
UnbearableBear
force-pushed
the
manu/parseXMLtoJSON
branch
from
e44cd0b
to
da2c573
Compare
UnbearableBear
force-pushed
the
manu/jsontocomponents
branch
from
a33ab20
to
3a2a5ed
Compare
lionelB
reviewed
Mar 12, 2019
packages/code-du-travail-frontend/src/ficheBuilder/utils/index.js
Outdated
Show resolved
Hide resolved
packages/code-du-travail-frontend/src/ficheBuilder/utils/getText.js
Outdated
Show resolved
Hide resolved
lionelB
reviewed
Mar 12, 2019
packages/code-du-travail-frontend/pages/fiche-service-public.js
Outdated
Show resolved
Hide resolved
lionelB
reviewed
Mar 12, 2019
packages/code-du-travail-frontend/src/FicheServicePublic/components/index.js
Outdated
Show resolved
Hide resolved
lionelB
reviewed
Mar 12, 2019
packages/code-du-travail-frontend/src/FicheServicePublic/utils/index.js
Outdated
Show resolved
Hide resolved
lionelB
reviewed
Mar 12, 2019
packages/code-du-travail-frontend/src/FicheServicePublic/index.js
Outdated
Show resolved
Hide resolved
lionelB
suggested changes
Mar 12, 2019
UnbearableBear
force-pushed
the
manu/parseXMLtoJSON
branch
from
e89ecc3
to
f582bb9
Compare
UnbearableBear
force-pushed
the
manu/jsontocomponents
branch
from
3a2a5ed
to
b2eedc6
Compare
lionelB
reviewed
Mar 12, 2019
packages/code-du-travail-frontend/src/FicheServicePublic/components/__tests__/Accordion.test.js
Outdated
Show resolved
Hide resolved
lionelB
reviewed
Mar 12, 2019
packages/code-du-travail-frontend/src/FicheServicePublic/components/__tests__/Accordion.test.js
Outdated
Show resolved
Hide resolved
lionelB
reviewed
Mar 14, 2019
| case "Tableau": | ||
| return <Table data={data} headingLevel={headingLevel} />; | ||
| case "Texte": | ||
| if (data.$.find(child => child.name === "Chapitre")) { |
There was a problem hiding this comment.
Est ce qu'on pourrait pas tester le niveau via headingLevel ?
Les accordéon de chapitre ne sont en général présent qu'au sous niveau 1
lionelB
reviewed
Mar 14, 2019
| @@ -0,0 +1,21 @@ | |||
| // beware, this one is recursive | |||
There was a problem hiding this comment.
Est ce qu'on pourrait pas bouger le fichier au niveau au dessus et l'appeller utils.js
lionelB
suggested changes
Mar 14, 2019
UnbearableBear
force-pushed
the
manu/jsontocomponents
branch
from
2dfc4eb
to
362e6b6
Compare
UnbearableBear
force-pushed
the
manu/parseXMLtoJSON
branch
from
f582bb9
to
1f01d55
Compare
UnbearableBear
force-pushed
the
manu/jsontocomponents
branch
from
362e6b6
to
7427731
Compare
UnbearableBear
added a commit
that referenced
this pull request
Mar 15, 2019
* feat: still working on json format of xml * feat: working on json format of xml * feat: finish json format of xml * refactor: remove pretty option on json file * fix: useless node_modules in gitignore * fix: wrong format in raw data, object instead of string * fix: remove useless python file and optimise json output * fix: wrong indent * fix: wrong regexp causing useless fiches to be indexed * fix: update wrong command line * fix: remove legacy file * feat: update format file * feat: update format file * feat: update fiches sp according to new filter * refactor: filters * refactor: change concat to be more readable * refactor: remove useless key in dataset * refactor: apply feedbacks * Première passe pour la génération dynamique de components (#578) * feat: first step in generating recursively react components from json * feat: create new components and add css vars * feat: add some new components * feat: add tabulator component * feat: add more components * refactor: change ficheBuilder into a component * feat: minor css changes * feat: add two more easy components * refactor: apply pr feedback * feat: add comment on special case * feat: add minimal test * test: update snapshot * test: adding more tests * test: add a few more tests * test: update snapshot * tests: remplace js mock file to json mock file * refactor: remove weird heading level * refactor: migrate css folder into ui * tests: add missing test * test: add missing snapshots * test: update snapshots
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Vous en pensez quoi ??