-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(localStorage error): do not crash if error "Failed to read the 'localStorage' property from 'Window': Access is denied for this document." is thrown #5999
Conversation
…ocalStorage' property from 'Window': Access is denied for this document." is thrown
@@ -85,8 +84,12 @@ const createCommonAgreementStore: StoreSlicePublicode< | |||
}, | |||
onRouteChange: (value) => { | |||
if (value === "not-selected") { | |||
if (window.localStorage) { | |||
window.localStorage.removeItem(STORAGE_KEY_AGREEMENT); | |||
try { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
le fix c'est juste d'ajouter un try/catch
); | ||
} else { | ||
window.localStorage.removeItem(STORAGE_KEY_AGREEMENT); | ||
try { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ici aussi
🎉 Deployment for commit 66b0cea : IngressesDocker images
|
This pull request sets up GitHub code scanning for this repository. Once the scans have completed and the checks have passed, the analysis results for this pull request branch will appear on this overview. Once you merge this pull request, the 'Security' tab will show more code scanning analysis results (for example, for the default branch). Depending on your configuration and choice of analysis tool, future pull requests will be annotated with code scanning analysis results. For more information about GitHub code scanning, check out the documentation. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
top merci !!!
@carolineBda Il faudrait limite passer sur chaque |
Oui j'ai fait ça, t'en a vu que j'ai oublié ? |
@carolineBda Nop, je demandais juste |
Fix error https://sentry.fabrique.social.gouv.fr/organizations/incubateur/issues/158729/?environment=production&project=107&query=is%3Aunresolved+http.url%3Ahttps%3A%2F%2Fcode.travail.gouv.fr%2Foutils%2Findemnite-licenciement&referrer=issue-stream&statsPeriod=30d&stream_index=1