feat(app): allow optional config

SocialGouv · Jul 29, 2020 · 31d9b50 · 31d9b50
1 parent 4775aa2
commit 31d9b50
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 4 deletions.
diff --git a/src/components/app/index.ts b/src/components/app/index.ts
@@ -35,7 +35,7 @@ export const create = (
     deployment: deploymentParams,
   }: {
     env: Environment;
-    config: Partial<AppConfig>;
+    config?: Partial<AppConfig>;
     deployment?: Partial<Omit<DeploymentParams, "containerPort">>;
   }
 ): { kind: string }[] => {
@@ -54,7 +54,7 @@ export const create = (
     defaultEnvParams, // set name as default if not provided
     gitlab(process.env),
     env.component(name) as AppConfig, // kosko env overrides
-    config // create options
+    config ?? {} // create options
   );
 
   const { containerPort, servicePort } = envParams;

diff --git a/src/components/hasura/index.ts b/src/components/hasura/index.ts
@@ -58,10 +58,9 @@ export const create = (
   ok(deployment);
 
   addPostgresUserSecret(deployment);
-
-  // todo: doesnt work ATM, we need to check if user+db are ready
   addWaitForPostgres(deployment);
 
   //
+
   return manifests;
 };