Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

POC tests auto a11y #1375

Merged
merged 30 commits into from
Jul 15, 2024
Merged

POC tests auto a11y #1375

merged 30 commits into from
Jul 15, 2024

Conversation

arthurlbrjc
Copy link
Contributor

@arthurlbrjc arthurlbrjc commented Jun 13, 2024

Apprentissage :

  • jest-axe
    • expect().toHaveNoViolations() à chaque changement d'état (apparation/disparition de contenu/zone, ...)
    • tester jest-axe/extend-expect
  • eslint/jsx-a11y
    • bien lire la description de la règle pour les reco de correction (parfois non applicable ou liée à une autre erreur qui prend le dessus)
    • strict et recommended ont l'air d'avoir les même règles

Pistes :

Copy link

socket-security bot commented Jun 13, 2024

New and removed dependencies detected. Learn more about Socket for GitHub ↗︎

Package New capabilities Transitives Size Publisher
npm/@types/jest-axe@3.5.9 Transitive: environment, eval +1 3.15 MB types
npm/jest-axe@9.0.0 Transitive: environment +7 3.32 MB nickcolley

🚮 Removed packages: npm/pass-emploi-web@0.0.0-use.local

View full report↗︎

@octo-theg
Copy link
Collaborator

@arthurlbrjc si tu veux pas t'embêter, ne check pas les tests, mais que les correctifs. Notamment sur les balises

, j'ai fait des trucs pour lesquels je ne suis pas (du tout) convaincu, et je pense que ça peut être plus propre.

.eslintrc.json Outdated Show resolved Hide resolved
components/jeune/BlocInformationJeune.tsx Outdated Show resolved Hide resolved
components/jeune/BlocInformationJeune.tsx Outdated Show resolved Hide resolved
components/jeune/BlocInformationJeuneFicheBeneficiaire.tsx Outdated Show resolved Hide resolved
components/ui/Form/Multiselection.tsx Outdated Show resolved Hide resolved
package.json Outdated Show resolved Hide resolved
components/jeune/TableauJeunes.tsx Outdated Show resolved Hide resolved
components/jeune/TableauJeunes.tsx Outdated Show resolved Hide resolved
components/rdv/OngletAgendaEtablissement.tsx Show resolved Hide resolved
@octo-theg octo-theg force-pushed the tech/poc-tests-a11y branch 3 times, most recently from bef32a0 to 52ec696 Compare July 9, 2024 15:16
Copy link

sonarcloud bot commented Jul 10, 2024

@octo-theg octo-theg merged commit 57944de into develop Jul 15, 2024
5 checks passed
@octo-theg octo-theg deleted the tech/poc-tests-a11y branch July 15, 2024 08:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants