fix(969): Page rendez-vous > gestion des borne inclues #517
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Due to complexity to put browser timezone in Next.js calls, we do not make initial call on server side
adgeg
force-pushed
the
fix/969-vue-rdv-conseiller-créer-un-rdv-la-veille-ko
branch
from
b835ce3
to
23ca50c
Compare
arthurlbrjc
reviewed
Sep 13, 2022
pages/mes-rendezvous.tsx
Outdated
| setDebutPeriode(DEBUT_RDVS_FUTURS.toFormat('dd/MM/yyyy')) | ||
| setFinPeriode(FIN_RDVS_FUTURS.toFormat('dd/MM/yyyy')) | ||
| setTrackingTitle(`${trackingTitle} futurs`) | ||
| if (rdvsSemaine) setRdvs(rdvsSemaine.map(rdvToListItem)) |
There was a problem hiding this comment.
Pas besoin du if vue que le méthode renvoie toujours au moins [].
There was a problem hiding this comment.
Ben justement, dans les tests ça me pétait sans ça…
There was a problem hiding this comment.
C'est peut-être le mock dans le test qui est mal écrit ? 🤔
There was a problem hiding this comment.
Tu pourras tester, mais j'en ai vraiment besoin, sinon un test pête
There was a problem hiding this comment.
J'ai corrigé en réorganisant un peu les tests, j'ai pas trop réussi à savoir ce qui merdait.
|
Kudos, SonarCloud Quality Gate passed! |
adgeg
deleted the
fix/969-vue-rdv-conseiller-créer-un-rdv-la-veille-ko
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.