Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Questions about contributing workflow #207

Closed
claudsonm opened this issue Sep 3, 2018 · 7 comments
Closed

Questions about contributing workflow #207

claudsonm opened this issue Sep 3, 2018 · 7 comments

Comments

@claudsonm
Copy link
Contributor

claudsonm commented Sep 3, 2018

Hi there,

I've got a PR merged, added the docs and everything, but things were not that intuitive to figure out. Maybe we need to describe things better on a CONTRIBUTING.md file?

Actually, my provider is not available on Packagist yet. If it is something automated, I think it should be done by now, because the generated GitHub repo is already up and running.

Also, about the docs, they are not available on the interface. Maybe it will only appear after change the SocialiteProviders/Documentation/docs/.vuepress/providers.js as well?

The PR's mentioned are #206 and this one.

@edit
After a few hours the package can be found on Packagist.

@claudsonm
Copy link
Contributor Author

Also, I noticed that the generated repository doesn't have any versioning or releases. This is a bad thing for composer, because the package version becomes "dev-master", throwing the message about the use of unbound versions.

I saw that the former maintainer of this package used to make some releases (manually?), but he doesn't have time anymore. How we should accomplish this?

@m1guelpf
Copy link
Member

m1guelpf commented Sep 4, 2018

@claudsonm I joined as a mantainer yesterday, and I'm still getting around everything. The Packagist issue (I didn't have publish access) should be solved by now, and I'll also ask the old mantainer about the release process. Will keep this issue updated!

@m1guelpf
Copy link
Member

m1guelpf commented Sep 4, 2018

I've manually tagged releases for all the providers that needed it, and also added missing providers to the website's navigation.

@bytestream
Copy link

@m1guelpf please can you tag Steam

@claudsonm
Copy link
Contributor Author

I've manually tagged releases for all the providers that needed it, and also added missing providers to the website's navigation.

Nice @m1guelpf .

And what about some packages not being displayed on the website (https://socialiteproviders.github.io/about.html)
There's anything missing to make it available?

Some examples are UFS and IFSP packages.

@atymic
Copy link
Member

atymic commented May 3, 2020

@claudsonm feel free to PR missing docs :)

@stale
Copy link

stale bot commented Jul 2, 2020

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale label Jul 2, 2020
@stale stale bot closed this as completed Jul 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants