Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release new version of all providers #480

Closed
atymic opened this issue Jul 29, 2020 · 6 comments
Closed

Release new version of all providers #480

atymic opened this issue Jul 29, 2020 · 6 comments

Comments

@atymic
Copy link
Member

atymic commented Jul 29, 2020

Release new major version dropping support for < 7.2

@atymic
Copy link
Member Author

atymic commented Aug 2, 2020

@lucasmichot is there any other changes we need to do before this apart from #484
Would be good to get them all lumped into a single 4.0.0 release

@lucasmichot
Copy link
Member

The major remaining problem is that many providers only support Guzzle 6, and not 7.
They would typically miss this check:

$postKey = (version_compare(ClientInterface::VERSION, '6') === 1) ? 'form_params' : 'body';

This needs to be fixed before the 4.0.0 release

@atymic
Copy link
Member Author

atymic commented Aug 3, 2020

Ahh, good catch. We should definitely get that fixed as well.
I was thinking about adding more types through the providers & the manager as well.

@lucasmichot
Copy link
Member

I was thinking about adding more types through the providers & the manager as well.

Do you mean types, like method and argument typing? If so, I am absolutely 👍

@stale
Copy link

stale bot commented Oct 3, 2020

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale label Oct 3, 2020
@atymic atymic removed the stale label Oct 3, 2020
@atymic
Copy link
Member Author

atymic commented Oct 25, 2020

Done via script :)

@atymic atymic closed this as completed Oct 25, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants