remove evil-terminal-cursor-changer

This package was added years ago but promptly removed due too buggy behaviours
with certain terminal and OS combination.

This commit entirely removed this package since there has been no update from
the upstream for years.

layers/+spacemacs/spacemacs-editing-visual/packages.el

@@ -27,7 +27,6 @@
 (defconst spacemacs-editing-visual-packages
   '(
     column-enforce-mode
-    (evil-terminal-cursor-changer :toggle (configuration-layer/package-used-p 'evil))
     (hide-comnt :location (recipe :fetcher github :repo "emacsmirror/hide-comnt"))
     highlight-indentation
     highlight-numbers
@@ -61,13 +60,6 @@
         :evil-leader "t C-8"))
     :spacediminish ("⑧" "8")))
 
-(defun spacemacs-editing-visual/init-evil-terminal-cursor-changer ()
-  (use-package evil-terminal-cursor-changer
-    :if (not (display-graphic-p))
-    :after evil
-    :defer t
-    :init (evil-terminal-cursor-changer-activate)))
-
 (defun spacemacs-editing-visual/init-hide-comnt ()
   (use-package hide-comnt
     :commands hide/show-comments-toggle

layers/+spacemacs/spacemacs-evil/packages.el

@@ -39,9 +39,6 @@
         evil-matchit
         evil-numbers
         evil-surround
-        ;; Temporarily disabled, pending the resolution of
-        ;; https://github.com/7696122/evil-terminal-cursor-changer/issues/8
-        ;; evil-terminal-cursor-changer
         evil-textobj-line
         evil-tutor
         (evil-unimpaired :location (recipe :fetcher local))
@@ -369,13 +366,6 @@
     (progn
       (global-evil-surround-mode 1))))
 
-(defun spacemacs-evil/init-evil-terminal-cursor-changer ()
-  (use-package evil-terminal-cursor-changer
-    :if (not (display-graphic-p))
-    :init (setq evil-visual-state-cursor 'box
-                evil-insert-state-cursor 'bar
-                evil-emacs-state-cursor 'hbar)))
-
 (defun spacemacs-evil/init-evil-textobj-line ()
   ;; No laziness here, the line text object should be available right away.
   (use-package evil-textobj-line))