New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert #247 #258

Merged

EulalieCoevoet merged 1 commit into SofaDefrost:master from hugtalbot:202401_revert_247

Jan 8, 2024

Collaborator

hugtalbot commented Jan 4, 2024

Further to deeper investigation in sofa-framework/sofa#4205, the previous #247 should be reverted.

Other files were already fixed by the team 👍

As an explanation/reminder, in a rigid case, the compliance data of the UncoupledCC has 7 inputs:

1 corresponding to the compliance for the translational dofs
6 corresponding to the rotation compliance matrix where zero values are possible OUTSIDE the diagonal


          Revert "Update all scenes not providing compliance info (or some 0 va…

20299c8

…lue) (SofaDefrost#247)"

This reverts commit ca99db2.

hugtalbot requested review from alxbilger and EulalieCoevoet

January 4, 2024 19:29

hugtalbot mentioned this pull request

[Lagrangian.Correction] Add callbacks to check zero compliance sofa-framework/sofa#4205

Merged

EulalieCoevoet merged commit 2f92d7a into SofaDefrost:master

1 of 4 checks passed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment