Skip to content

Commit

Permalink
Turn OFF flake8 in python-app.yml; it's too restrictive. Fix pytest c…
Browse files Browse the repository at this point in the history
…all.

Change workflow to run 'pytest tests', seems to work.
Run pytest with -v, so we see which tests are being run.
  • Loading branch information
Aditya Gurajada authored and gapisback committed May 14, 2023
1 parent ab3d10a commit 79ed9b2
Showing 1 changed file with 8 additions and 5 deletions.
13 changes: 8 additions & 5 deletions .github/workflows/python-app.yml
Original file line number Diff line number Diff line change
Expand Up @@ -28,12 +28,15 @@ jobs:
python -m pip install --upgrade pip
pip install flake8 pytest
if [ -f requirements.txt ]; then pip install -r requirements.txt; fi
- name: Lint with flake8
run: |
# flake8 seems way too restrictive over pylint. Turn this OFF.
#! - name: Lint with flake8
#! run: |
# stop the build if there are Python syntax errors or undefined names
flake8 . --count --select=E9,F63,F7,F82 --show-source --statistics
#! flake8 . --count --select=E9,F63,F7,F82 --show-source --statistics
# exit-zero treats all errors as warnings. The GitHub editor is 127 chars wide
flake8 . --count --exit-zero --max-complexity=10 --max-line-length=127 --statistics
#! flake8 . --count --exit-zero --max-complexity=10 --max-line-length=127 --statistics

- name: Test with pytest
run: |
pytest
pytest -v tests

0 comments on commit 79ed9b2

Please sign in to comment.